From: Rene Herman <rene.herman@keyaccess.nl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Cyrill Gorcunov <gorcunov@gmail.com>,
geert@linux-m68k.org, zippel@linux-m68k.org, schwab@suse.de,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH] init - fix building bug and potential buffer overflow
Date: Fri, 16 May 2008 00:44:27 +0200 [thread overview]
Message-ID: <482CBCCB.8070101@keyaccess.nl> (raw)
In-Reply-To: <alpine.LFD.1.10.0805151406030.3019@woody.linux-foundation.org>
On 15-05-08 23:15, Linus Torvalds wrote:
> Talking about cleanups, why the *hell* does print_fn_descriptor_symbol()
> take an "unsigned long", when every single user would want to give it a
> pointer?
>
> Would somebody please want to move that cast into the macro (or better
> yet, make it an inline function that takes a 'void *'), and remove all the
> casts from the callers?
[ ... ]
> + print_fn_descriptor_symbol("calling %s()\n",
> + (unsigned long) call);
And while that person is at it, could he or she please remove the silly
() from the "foo+0x0/0x1234()" (or the "foo+0x0/0x1234 [bar]()" or the
"0x12345678()").
Rene.
next prev parent reply other threads:[~2008-05-15 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 15:44 [PATCH] init - fix building bug and potential buffer overflow Cyrill Gorcunov
2008-05-15 17:58 ` Andrew Morton
2008-05-15 18:05 ` Cyrill Gorcunov
2008-05-15 19:47 ` Geert Uytterhoeven
2008-05-15 20:22 ` Cyrill Gorcunov
2008-05-15 20:49 ` Andrew Morton
2008-05-15 21:15 ` Linus Torvalds
2008-05-15 21:45 ` Andrew Morton
2008-05-15 23:41 ` [PATCH] Add a void * alternative to print_fn_descriptor_symbol() Abhijit Menon-Sen
2008-05-16 1:47 ` [PATCH] init - fix building bug and potential buffer overflow Linus Torvalds
2008-05-15 22:44 ` Rene Herman [this message]
2008-05-16 3:29 ` Cyrill Gorcunov
2008-05-16 4:17 ` Cyrill Gorcunov
2008-05-16 7:00 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482CBCCB.8070101@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schwab@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox