From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757215AbYERIst (ORCPT ); Sun, 18 May 2008 04:48:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752669AbYERIsh (ORCPT ); Sun, 18 May 2008 04:48:37 -0400 Received: from mx1.ukfsn.org ([77.75.108.10]:39839 "EHLO mail.ukfsn.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753008AbYERIsf (ORCPT ); Sun, 18 May 2008 04:48:35 -0400 Message-ID: <482FED60.7060405@dgreaves.com> Date: Sun, 18 May 2008 09:48:32 +0100 From: David Greaves User-Agent: Mozilla-Thunderbird 2.0.0.12 (X11/20080406) MIME-Version: 1.0 To: Eric Sandeen CC: David Chinner , xfs@oss.sgi.com, "'linux-kernel@vger.kernel.org'" , Christoph Hellwig , LinuxRaid Subject: Re: Regression- XFS won't mount on partitioned md array References: <482DC043.5000307@dgreaves.com> <482DD981.5070004@sandeen.net> <482EEFDA.50101@dgreaves.com> <482EF6A7.2020909@sandeen.net> <482F67D9.70400@sandeen.net> <482FBD4C.20608@sandeen.net> In-Reply-To: <482FBD4C.20608@sandeen.net> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Sandeen wrote: > Eric Sandeen wrote: >> Eric Sandeen wrote: >> >>> I'll see if I have a little time today to track down the problem. >> >> Does this patch fix it for you? Does for me though I can't yet explain >> why ;) >> >> http://www.linux.sgi.com/archives/xfs/2008-05/msg00190.html >> >> -Eric Yes, this fixes it for me - thanks :) > So what's happening is that xfs is trying to read a page-sized IO from > the last sector of the log... which goes off the end of the device. > This looks like another regression introduced by > a9759f2de38a3443d5107bddde03b4f3f550060e, but fixed by Christoph's patch > in the URL above, which should be headed towards -stable. Damn, I guess I misread my bisect readings when things crashed then. Still, I said 'around' :) > (aside: it seems that this breaks any external log setup where the log > consists of the entire device... but I'd have expected the xfsqa suite > to catch this...?) > > The patch avoids the problem by looking for some extra locking but it > seems to me that the root cause is that the buffer being read at this > point doesn't have it's b_offset, the offset in it's page, set. Might > be another little buglet but harmless it seems. mmmm 'little buglets' in the filesystem holding a few Tb of data... mmmm Anything I can do to help find that? I suspect not if you can reproduce it. Anyhow - thanks again. David PS I'll be back soon, back in 2.6.23 I was hitting a hibernate/xfs bug which I've been avoiding by powering down. Well, it's still there in 2.6.25.3...