2.6.26-rc* - CONFIG_FRAME_WARN help text clarification...

2.6.26-rc* - CONFIG_FRAME_WARN help text clarification...

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

I hit this during a 'make oldconfig', and had to ponder and dig through the
Makefiles to see if pre-4.4 should set it to 0, or not.

Make it clear to people who hit this in a 'make oldconfig' that it's safe to
set it so that whenever their box finally *does* get gcc 4.4, it will be used.

Signed-Off-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>

*** linux-2.6.26-rc2-mm1/lib/Kconfig.debug.gccvers	2008-05-17 09:14:05.000000000 -0400
--- linux-2.6.26-rc2-mm1/lib/Kconfig.debug	2008-05-17 09:15:45.000000000 -0400
***************
*** 34,40 ****
  	  Tell gcc to warn at build time for stack frames larger than this.
  	  Setting this too low will cause a lot of warnings.
  	  Setting it to 0 disables the warning.
! 	  Requires gcc 4.4
  
  config MAGIC_SYSRQ
  	bool "Magic SysRq key"
--- 34,40 ----
  	  Tell gcc to warn at build time for stack frames larger than this.
  	  Setting this too low will cause a lot of warnings.
  	  Setting it to 0 disables the warning.
! 	  Requires gcc 4.4, but is safe to set for earlier releases.
  
  config MAGIC_SYSRQ
  	bool "Magic SysRq key"


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.26-rc* - CONFIG_FRAME_WARN help text clarification...

[Andi Kleen]

Valdis.Kletnieks@vt.edu wrote:
> I hit this during a 'make oldconfig', and had to ponder and dig through the
> Makefiles to see if pre-4.4 should set it to 0, or not.
> 
> Make it clear to people who hit this in a 'make oldconfig' that it's safe to
> set it so that whenever their box finally *does* get gcc 4.4, it will be used.

I don't think "doesn't work" is the same as "safe".

Also submit patches always with diff -u

-Andi