* [PATCH (resend)] Bsdacct: stir up comments around acct_process
@ 2008-05-19 7:45 Pavel Emelyanov
0 siblings, 0 replies; only message in thread
From: Pavel Emelyanov @ 2008-05-19 7:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: Randy Dunlap, Linux Kernel Mailing List
Fix the one describing what this function is and add one
more - about locking absence around pid namespaces loop.
Changes from v1: fixed misprints pointed out by Randy.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
---
diff --git a/kernel/acct.c b/kernel/acct.c
index 0feba97..d7b670c 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -657,7 +657,8 @@ static void acct_process_in_ns(struct pid_namespace *ns)
}
/**
- * acct_process - now just a wrapper around do_acct_process
+ * acct_process - now just a wrapper around acct_process_in_ns,
+ * which in turn is a wrapper around do_acct_process.
*
* handles process accounting for an exiting task
*/
@@ -665,6 +666,11 @@ void acct_process(void)
{
struct pid_namespace *ns;
+ /*
+ * This loop is safe lockless, since current is still
+ * alive and holds its namespace, which in turn holds
+ * its parent.
+ */
for (ns = task_active_pid_ns(current); ns != NULL; ns = ns->parent)
acct_process_in_ns(ns);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-05-19 7:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-19 7:45 [PATCH (resend)] Bsdacct: stir up comments around acct_process Pavel Emelyanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox