public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* remove used member(struct rcu_data::rcu_tasklet)
@ 2008-05-19  7:55 Lai Jiangshan
  2008-05-19 12:29 ` Paul E. McKenney
  0 siblings, 1 reply; 2+ messages in thread
From: Lai Jiangshan @ 2008-05-19  7:55 UTC (permalink / raw)
  To: Linux Kernel Mailing List, paulmck

	Since softirq works for rcu reclaimer, rcu_tasklet is unused now.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>

diff --git a/kernel/rcupreempt.c b/kernel/rcupreempt.c
index e1cdf19..4270de6 100644
--- a/kernel/rcupreempt.c
+++ b/kernel/rcupreempt.c
@@ -82,7 +82,6 @@ struct rcu_data {
 	spinlock_t	lock;		/* Protect rcu_data fields. */
 	long		completed;	/* Number of last completed batch. */
 	int		waitlistcount;
-	struct tasklet_struct rcu_tasklet;
 	struct rcu_head *nextlist;
 	struct rcu_head **nexttail;
 	struct rcu_head *waitlist[GP_STAGES];



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: remove used member(struct rcu_data::rcu_tasklet)
  2008-05-19  7:55 remove used member(struct rcu_data::rcu_tasklet) Lai Jiangshan
@ 2008-05-19 12:29 ` Paul E. McKenney
  0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2008-05-19 12:29 UTC (permalink / raw)
  To: Lai Jiangshan; +Cc: Linux Kernel Mailing List

On Mon, May 19, 2008 at 03:55:35PM +0800, Lai Jiangshan wrote:
> 	Since softirq works for rcu reclaimer, rcu_tasklet is unused now.

good catch!

Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> 
> diff --git a/kernel/rcupreempt.c b/kernel/rcupreempt.c
> index e1cdf19..4270de6 100644
> --- a/kernel/rcupreempt.c
> +++ b/kernel/rcupreempt.c
> @@ -82,7 +82,6 @@ struct rcu_data {
>  	spinlock_t	lock;		/* Protect rcu_data fields. */
>  	long		completed;	/* Number of last completed batch. */
>  	int		waitlistcount;
> -	struct tasklet_struct rcu_tasklet;
>  	struct rcu_head *nextlist;
>  	struct rcu_head **nexttail;
>  	struct rcu_head *waitlist[GP_STAGES];
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-19 12:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-19  7:55 remove used member(struct rcu_data::rcu_tasklet) Lai Jiangshan
2008-05-19 12:29 ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox