From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765867AbYESNlm (ORCPT ); Mon, 19 May 2008 09:41:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762973AbYESNfK (ORCPT ); Mon, 19 May 2008 09:35:10 -0400 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:12602 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764934AbYESNfI (ORCPT ); Mon, 19 May 2008 09:35:08 -0400 Message-ID: <48318209.9060101@qumranet.com> Date: Mon, 19 May 2008 16:35:05 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Ingo Molnar CC: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Make LIST_POISON less deadly References: <1211125094-32167-1-git-send-email-avi@qumranet.com> <20080519130151.GE13546@elte.hu> <48317E2B.2030304@qumranet.com> <20080519132250.GA20793@elte.hu> In-Reply-To: <20080519132250.GA20793@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > * Avi Kivity wrote: > > >>> i'd suggest to add an ARCH_ILLEGAL_POINTER define instead, which >>> defaults to zero and gets added to pointer-ish poison values. That >>> makes it both simpler and also it does not need any include/asm >>> changes because ARCH_ILLEGAL_POINTER can be set from the Kconfig >>> space. >>> >> Right. >> >> How much unmapped space do we have on i386 or other archs? The deltas >> added to ARCH_ILLEGAL_POINTER will have to be limited to that. >> > > can we get away with having the offset default to zero, and all poison > values remain unchanged if that? Then 64-bit x86 could just set the > offset to 2^63 and we wont have to worry about 32-bit x86 at all ... > > i.e. start small with this and only have an effect on 64-bit x86. > Sure, will post an updated patch. -- error compiling committee.c: too many arguments to function