From: Andrea Righi <righiandr@users.sourceforge.net>
To: balbir@linux.vnet.ibm.com
Cc: Shailabh Nagar <nagar@watson.ibm.com>,
Mark Seger <Mark.Seger@hp.com>, Jes Sorensen <jes@sgi.com>,
Chris Sturtivant <csturtiv@sgi.com>, Tony Ernst <tee@sgi.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] distinct tgid/tid I/O statistics
Date: Mon, 19 May 2008 22:08:45 +0200 [thread overview]
Message-ID: <4831DE4D.7020602@users.sourceforge.net> (raw)
In-Reply-To: <4831C7E7.2090804@users.sourceforge.net>
Andrea Righi wrote:
> Balbir Singh wrote:
>>> +
>>> + if (!whole) {
>>> +#ifdef CONFIG_TASK_XACCT
>> Can't we abstract this into a function for ease?
>
BTW, CONFIG_TASK_IO_ACCOUNTING depends on CONFIG_TASK_XACCT, so I think
we can just remove those #ifdefs inside CONFIG_TASK_IO_ACCOUNTING.
-Andrea
next prev parent reply other threads:[~2008-05-19 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 20:38 [PATCH] distinct tgid/tid I/O statistics (was: taskstats and /proc/.../io asymmetry?) Andrea Righi
2008-05-19 16:36 ` Andrea Righi
2008-05-19 17:49 ` Balbir Singh
2008-05-19 18:33 ` [PATCH] distinct tgid/tid I/O statistics Andrea Righi
2008-05-19 20:08 ` Andrea Righi [this message]
2008-05-19 21:57 ` [PATCH v2] " Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831DE4D.7020602@users.sourceforge.net \
--to=righiandr@users.sourceforge.net \
--cc=Mark.Seger@hp.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=csturtiv@sgi.com \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nagar@watson.ibm.com \
--cc=tee@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox