From: "H. Peter Anvin" <hpa@zytor.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [2.6 patch] asm-generic/int-ll64.h: always provide __{s,u}64
Date: Mon, 19 May 2008 15:01:03 -0700 [thread overview]
Message-ID: <4831F89F.5060106@zytor.com> (raw)
In-Reply-To: <20080519215452.GK17716@cs181133002.pp.htv.fi>
Adrian Bunk wrote:
> Several compilers offer "long long" without claiming to support C99.
>
> Considering how frequent __s64/__u64 are used our userspace headers are
> anyway unusable without __s64/__u64 available.
>
> Always offer __s64/__u64 to non-gcc non-C99 compilers - if they provide
> "long long" that makes the headers compiling and if they don't they are
> anyway screwed.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
This makes sense to me (I did, however, not want to make that change
part of the same changeset - one change at a time.)
The main reason for not just blindly using "long long" has to do with
the use of gcc -ansi -pedantic in userspace, which is already taken care
of by the use of __extension__ in the __GNUC__ clause.
Acked-by: H. Peter Anvin <hpa@zytor.com>
next prev parent reply other threads:[~2008-05-19 22:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-19 21:54 [2.6 patch] asm-generic/int-ll64.h: always provide __{s,u}64 Adrian Bunk
2008-05-19 22:01 ` H. Peter Anvin [this message]
2008-05-19 22:27 ` Harvey Harrison
2008-05-19 22:29 ` H. Peter Anvin
2008-05-19 22:32 ` Adrian Bunk
2008-05-19 23:51 ` H. Peter Anvin
2008-05-20 0:13 ` Adrian Bunk
2008-05-20 0:17 ` H. Peter Anvin
2008-05-20 0:33 ` Adrian Bunk
2008-05-20 1:16 ` H. Peter Anvin
2008-05-20 9:09 ` Adrian Bunk
2008-05-20 14:54 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831F89F.5060106@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox