From: Rene Herman <rene.herman@keyaccess.nl>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Adam Belay <ambx1@neo.rr.com>, Adam M Belay <abelay@mit.edu>,
Li Shaohua <shaohua.li@intel.com>,
Matthieu Castet <castet.matthieu@free.fr>,
Thomas Renninger <trenn@suse.de>,
Jaroslav Kysela <perex@perex.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [patch 1/4] PNP: make pnp_{port,mem,etc}_start(), et al work for invalid resources
Date: Tue, 20 May 2008 00:23:02 +0200 [thread overview]
Message-ID: <4831FDC6.3090709@keyaccess.nl> (raw)
In-Reply-To: <20080515220754.366570486@ldl.fc.hp.com>
On 16-05-08 00:07, Bjorn Helgaas wrote:
> Some callers use pnp_port_start() and similar functions without
> making sure the resource is valid. This patch makes us fall
> back to returning the initial values if the resource is not
> valid or not even present.
>
> This mostly preserves the previous behavior, where we would just
> return the initial values set by pnp_init_resource_table(). The
> original 2.6.25 code didn't range-check the "bar", so it would
> return garbage if the bar exceeded the table size. This code
> returns sensible values instead.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: Rene Herman <rene.herman@gmail.com>
Rene.
next prev parent reply other threads:[~2008-05-19 23:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 22:07 [patch 0/4] PNP: convert resource table to dynamic list, v2 Bjorn Helgaas
2008-05-15 22:07 ` [patch 1/4] PNP: make pnp_{port,mem,etc}_start(), et al work for invalid resources Bjorn Helgaas
2008-05-19 22:23 ` Rene Herman [this message]
2008-05-15 22:07 ` [patch 2/4] PNP: replace pnp_resource_table with dynamically allocated resources Bjorn Helgaas
2008-05-19 23:14 ` Rene Herman
2008-05-19 23:41 ` Bjorn Helgaas
2008-05-22 21:18 ` Rene Herman
2008-05-15 22:07 ` [patch 3/4] PNP: remove ratelimit on add resource failures Bjorn Helgaas
2008-05-19 23:15 ` Rene Herman
2008-05-15 22:07 ` [patch 4/4] PNP: dont sort by type in /sys/.../resources Bjorn Helgaas
2008-05-19 22:42 ` Adam M Belay
2008-05-19 23:41 ` Bjorn Helgaas
2008-05-19 23:22 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4831FDC6.3090709@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=abelay@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=ambx1@neo.rr.com \
--cc=bjorn.helgaas@hp.com \
--cc=castet.matthieu@free.fr \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shaohua.li@intel.com \
--cc=tiwai@suse.de \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox