public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] pnp: remove printk() with outdated version
@ 2008-05-19 21:54 Adrian Bunk
  2008-05-19 22:02 ` Bjorn Helgaas
  2008-05-19 22:24 ` Rene Herman
  0 siblings, 2 replies; 9+ messages in thread
From: Adrian Bunk @ 2008-05-19 21:54 UTC (permalink / raw)
  To: Rene Herman, Bjorn Helgaas; +Cc: linux-kernel

There's no point in printing some ancient version number forever.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
index 20771b7..d924798 100644
--- a/drivers/pnp/core.c
+++ b/drivers/pnp/core.c
@@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
 
 static int __init pnp_init(void)
 {
-	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
 	return bus_register(&pnp_bus_type);
 }
 


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [2.6 patch] pnp: remove printk() with outdated version
  2008-05-19 21:54 [2.6 patch] pnp: remove printk() with outdated version Adrian Bunk
@ 2008-05-19 22:02 ` Bjorn Helgaas
  2008-05-19 22:06   ` Randy.Dunlap
                     ` (2 more replies)
  2008-05-19 22:24 ` Rene Herman
  1 sibling, 3 replies; 9+ messages in thread
From: Bjorn Helgaas @ 2008-05-19 22:02 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Rene Herman, linux-kernel, Adam M Belay, Adam Belay

On Monday 19 May 2008 03:54:19 pm Adrian Bunk wrote:
> There's no point in printing some ancient version number forever.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Adam's the maintainer, so you really should ask him (cc'd).
Personally, I agree that it isn't really useful anymore.

> ---
> acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
> index 20771b7..d924798 100644
> --- a/drivers/pnp/core.c
> +++ b/drivers/pnp/core.c
> @@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
>  
>  static int __init pnp_init(void)
>  {
> -	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
>  	return bus_register(&pnp_bus_type);
>  }
>  
> 
> 



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [2.6 patch] pnp: remove printk() with outdated version
  2008-05-19 22:02 ` Bjorn Helgaas
@ 2008-05-19 22:06   ` Randy.Dunlap
  2008-05-19 22:22   ` Adrian Bunk
  2008-05-19 22:36   ` Adam M Belay
  2 siblings, 0 replies; 9+ messages in thread
From: Randy.Dunlap @ 2008-05-19 22:06 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Adrian Bunk, Rene Herman, linux-kernel, Adam M Belay, Adam Belay

On Mon, 19 May 2008, Bjorn Helgaas wrote:

> On Monday 19 May 2008 03:54:19 pm Adrian Bunk wrote:
> > There's no point in printing some ancient version number forever.
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> Adam's the maintainer, so you really should ask him (cc'd).
> Personally, I agree that it isn't really useful anymore.

Ditto.  Thanks.

> > ---
> > acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
> > index 20771b7..d924798 100644
> > --- a/drivers/pnp/core.c
> > +++ b/drivers/pnp/core.c
> > @@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
> >  
> >  static int __init pnp_init(void)
> >  {
> > -	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
> >  	return bus_register(&pnp_bus_type);
> >  }
> >  
> > 
> > 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
~Randy

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [2.6 patch] pnp: remove printk() with outdated version
  2008-05-19 22:02 ` Bjorn Helgaas
  2008-05-19 22:06   ` Randy.Dunlap
@ 2008-05-19 22:22   ` Adrian Bunk
  2008-05-19 22:36   ` Adam M Belay
  2 siblings, 0 replies; 9+ messages in thread
From: Adrian Bunk @ 2008-05-19 22:22 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: Rene Herman, linux-kernel, Adam M Belay, Adam Belay

On Mon, May 19, 2008 at 04:02:46PM -0600, Bjorn Helgaas wrote:
> On Monday 19 May 2008 03:54:19 pm Adrian Bunk wrote:
> > There's no point in printing some ancient version number forever.
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> Adam's the maintainer, so you really should ask him (cc'd).

Sorry, I thought there was a patch pending listing you as the new 
maintainer, but that could be an error on my side.

> Personally, I agree that it isn't really useful anymore.
> 
> > ---
> > acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
> > index 20771b7..d924798 100644
> > --- a/drivers/pnp/core.c
> > +++ b/drivers/pnp/core.c
> > @@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
> >  
> >  static int __init pnp_init(void)
> >  {
> > -	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
> >  	return bus_register(&pnp_bus_type);
> >  }

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [2.6 patch] pnp: remove printk() with outdated version
  2008-05-19 21:54 [2.6 patch] pnp: remove printk() with outdated version Adrian Bunk
  2008-05-19 22:02 ` Bjorn Helgaas
@ 2008-05-19 22:24 ` Rene Herman
  1 sibling, 0 replies; 9+ messages in thread
From: Rene Herman @ 2008-05-19 22:24 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Rene Herman, Bjorn Helgaas, linux-kernel

On 19-05-08 23:54, Adrian Bunk wrote:

> There's no point in printing some ancient version number forever.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
> index 20771b7..d924798 100644
> --- a/drivers/pnp/core.c
> +++ b/drivers/pnp/core.c
> @@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
>  
>  static int __init pnp_init(void)
>  {
> -	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
>  	return bus_register(&pnp_bus_type);
>  }

Acked-by; Rene Herman <rene.herman@gmail.com>

Rene.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [2.6 patch] pnp: remove printk() with outdated version
  2008-05-19 22:02 ` Bjorn Helgaas
  2008-05-19 22:06   ` Randy.Dunlap
  2008-05-19 22:22   ` Adrian Bunk
@ 2008-05-19 22:36   ` Adam M Belay
  2 siblings, 0 replies; 9+ messages in thread
From: Adam M Belay @ 2008-05-19 22:36 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: Adrian Bunk, Rene Herman, linux-kernel, Adam Belay

Acked.

Thanks,
Adam

Quoting Bjorn Helgaas <bjorn.helgaas@hp.com>:

> On Monday 19 May 2008 03:54:19 pm Adrian Bunk wrote:
>> There's no point in printing some ancient version number forever.
>>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> Adam's the maintainer, so you really should ask him (cc'd).
> Personally, I agree that it isn't really useful anymore.
>
>> ---
>> acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git 
>> a/drivers/pnp/core.c b/drivers/pnp/core.c
>> index 20771b7..d924798 100644
>> --- a/drivers/pnp/core.c
>> +++ b/drivers/pnp/core.c
>> @@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
>>
>>  static int __init pnp_init(void)
>>  {
>> -	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
>>  	return bus_register(&pnp_bus_type);
>>  }
>>
>>
>>
>
>
>



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [2.6 patch] pnp: remove printk() with outdated version
@ 2008-08-06 21:10 Adrian Bunk
  2008-08-06 21:38 ` Rene Herman
  0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2008-08-06 21:10 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Rene Herman, Bjorn Helgaas, Adam M Belay, linux-kernel

There's no point in printing some ancient version number forever.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by; Rene Herman <rene.herman@gmail.com>
Acked-by; Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by; Adam M Belay <abelay@MIT.EDU>

---

This patch has been sent on:
- 20 May 2008

acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
index 20771b7..d924798 100644
--- a/drivers/pnp/core.c
+++ b/drivers/pnp/core.c
@@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
 
 static int __init pnp_init(void)
 {
-	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
 	return bus_register(&pnp_bus_type);
 }
 


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [2.6 patch] pnp: remove printk() with outdated version
  2008-08-06 21:10 Adrian Bunk
@ 2008-08-06 21:38 ` Rene Herman
  2008-08-10 10:48   ` Adrian Bunk
  0 siblings, 1 reply; 9+ messages in thread
From: Rene Herman @ 2008-08-06 21:38 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Andrew Morton, Rene Herman, Bjorn Helgaas, Adam M Belay,
	linux-kernel

On 06-08-08 23:10, Adrian Bunk wrote:

> There's no point in printing some ancient version number forever.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Acked-by; Rene Herman <rene.herman@gmail.com>
> Acked-by; Bjorn Helgaas <bjorn.helgaas@hp.com>
> Acked-by; Adam M Belay <abelay@MIT.EDU>

semicolons... :-/

> ---
> 
> This patch has been sent on:
> - 20 May 2008
> 
> acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
> index 20771b7..d924798 100644
> --- a/drivers/pnp/core.c
> +++ b/drivers/pnp/core.c
> @@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
>  
>  static int __init pnp_init(void)
>  {
> -	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
>  	return bus_register(&pnp_bus_type);
>  }

Rene.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [2.6 patch] pnp: remove printk() with outdated version
  2008-08-06 21:38 ` Rene Herman
@ 2008-08-10 10:48   ` Adrian Bunk
  0 siblings, 0 replies; 9+ messages in thread
From: Adrian Bunk @ 2008-08-10 10:48 UTC (permalink / raw)
  To: Rene Herman
  Cc: Andrew Morton, Rene Herman, Bjorn Helgaas, Adam M Belay,
	linux-kernel

On Wed, Aug 06, 2008 at 11:38:25PM +0200, Rene Herman wrote:
> On 06-08-08 23:10, Adrian Bunk wrote:
>
>> There's no point in printing some ancient version number forever.
>>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>> Acked-by; Rene Herman <rene.herman@gmail.com>
>> Acked-by; Bjorn Helgaas <bjorn.helgaas@hp.com>
>> Acked-by; Adam M Belay <abelay@MIT.EDU>
>
> semicolons... :-/
>...

Fixed patch below.

> Rene.

cu
Adrian


<--  snip  -->


There's no point in printing some ancient version number forever.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: Rene Herman <rene.herman@gmail.com>
Acked-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: Adam M Belay <abelay@MIT.EDU>

---
There's no point in printing some ancient version number forever.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
acef517cfbe3cd741f8884311ef6fc2dfbeb1a4d diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
index 20771b7..d924798 100644
--- a/drivers/pnp/core.c
+++ b/drivers/pnp/core.c
@@ -209,7 +209,6 @@ void __pnp_remove_device(struct pnp_dev *dev)
 
 static int __init pnp_init(void)
 {
-	printk(KERN_INFO "Linux Plug and Play Support v0.97 (c) Adam Belay\n");
 	return bus_register(&pnp_bus_type);
 }
 


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2008-08-10 10:50 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-19 21:54 [2.6 patch] pnp: remove printk() with outdated version Adrian Bunk
2008-05-19 22:02 ` Bjorn Helgaas
2008-05-19 22:06   ` Randy.Dunlap
2008-05-19 22:22   ` Adrian Bunk
2008-05-19 22:36   ` Adam M Belay
2008-05-19 22:24 ` Rene Herman
  -- strict thread matches above, loose matches on Subject: below --
2008-08-06 21:10 Adrian Bunk
2008-08-06 21:38 ` Rene Herman
2008-08-10 10:48   ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox