From: Javier Herrero <jherrero@hvsistemas.es>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Bryan Wu <cooloney@kernel.org>
Subject: Re: b4aa54d951d38d7a989d6b6385494ef5ea7371d7 breaks some serial configurations
Date: Tue, 20 May 2008 10:07:11 +0200 [thread overview]
Message-ID: <483286AF.2090302@hvsistemas.es> (raw)
In-Reply-To: <20080520073556.GA1090@flint.arm.linux.org.uk>
Does the problem arise due to the change of inclusion order of
asm/serial.h (from after 8250.h to before 8250.h) ?
Russell King escribió:
> The above commit contains the following patch:
>
> | --- a/drivers/serial/8250.c
> | +++ b/drivers/serial/8250.c
> | @@ -43,6 +43,7 @@
> |
> | #include <asm/io.h>
> | #include <asm/irq.h>
> | +#include <asm/serial.h>
> |
> | #include "8250.h"
> |
> | @@ -92,8 +93,6 @@ static unsigned int nr_uarts = CONFIG_SERIAL_8250_RUNTIME_UARTS;
> | */
> | #define CONFIG_HUB6 1
> |
> | -#include <asm/serial.h>
> | -
> | /*
> | * SERIAL_PORT_DFNS tells us about built-in ports that have no
> | * standard enumeration mechanism. Platforms that can find all
>
> The code between these two hunks contains the following:
>
> | #ifdef CONFIG_SERIAL_8250_DETECT_IRQ
> | #define CONFIG_SERIAL_DETECT_IRQ 1
> | #endif
> | #ifdef CONFIG_SERIAL_8250_MANY_PORTS
> | #define CONFIG_SERIAL_MANY_PORTS 1
> | #endif
>
> and asm-*/serial.h contains:
>
> | $ grep 'CONFIG_SERIAL_DETECT\|CONFIG_SERIAL_MANY' include/asm-*/serial.h
> | include/asm-alpha/serial.h:#ifdef CONFIG_SERIAL_DETECT_IRQ
> | include/asm-m68k/serial.h:#ifdef CONFIG_SERIAL_DETECT_IRQ
> | include/asm-mn10300/serial.h:#ifdef CONFIG_SERIAL_DETECT_IRQ
> | include/asm-mn10300/serial.h:#ifdef CONFIG_SERIAL_MANY_PORTS
> | include/asm-x86/serial.h:#ifdef CONFIG_SERIAL_DETECT_IRQ
>
> So, all these ifdefs are now useless.
>
--
------------------------------------------------------------------------
Javier Herrero EMAIL: jherrero@hvsistemas.com
HV Sistemas S.L. PHONE: +34 949 336 806
Los Charcones, 17A FAX: +34 949 336 792
19170 El Casar - Guadalajara - Spain WEB: http://www.hvsistemas.com
next prev parent reply other threads:[~2008-05-20 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 7:35 b4aa54d951d38d7a989d6b6385494ef5ea7371d7 breaks some serial configurations Russell King
2008-05-20 8:07 ` Javier Herrero [this message]
2008-05-20 8:32 ` Russell King
2008-05-20 10:52 ` Javier Herrero
2008-05-20 23:13 ` Russell King
2008-05-20 23:21 ` Mike Frysinger
2008-05-21 5:45 ` Javier Herrero
2008-05-21 6:38 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483286AF.2090302@hvsistemas.es \
--to=jherrero@hvsistemas.es \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox