From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933140AbYETPSS (ORCPT ); Tue, 20 May 2008 11:18:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756397AbYETPSD (ORCPT ); Tue, 20 May 2008 11:18:03 -0400 Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:35022 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475AbYETPSB (ORCPT ); Tue, 20 May 2008 11:18:01 -0400 Message-ID: <4832EBA7.2040007@qumranet.com> Date: Tue, 20 May 2008 18:17:59 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Andi Kleen CC: Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org, Sam Ravnborg Subject: Re: [PATCH] Make LIST_POISON less deadly (v3) References: <1211283565-30671-1-git-send-email-avi@qumranet.com> <87fxsdgg6f.fsf@basil.nowhere.org> In-Reply-To: <87fxsdgg6f.fsf@basil.nowhere.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andi Kleen wrote: > Avi Kivity writes: > >> >> +config ILLEGAL_POINTER_VALUE >> + hex >> + default 0 if X86_32 >> + default 0xffffc10000000000 if X86_64 >> > > Don't make it exactly 0xffffc10000000000 but 0xffffc10000000000 + 0x1000000 > or so, otherwise list_entry() users which subtract offsets would still > end up in user space and there might be actually something in there > by default. > The poison code adds a large offset (>1MB) so we're safe here. -- error compiling committee.c: too many arguments to function