From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Jones <davej@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [X86] Remove unnecessary code in 64bit CPU identification.
Date: Tue, 20 May 2008 12:42:08 -0700 [thread overview]
Message-ID: <48332990.9030609@zytor.com> (raw)
In-Reply-To: <20080520191812.GB31805@redhat.com>
Dave Jones wrote:
>
> Moving along the same direction.. Moving the vendor specific bits out of setup_64.c
> into cpu/ would go a long way towards killing of setup64.c. I took a first pass at doing this
> in the diff below. So far I only looked at the AMD specific bits, and haven't done
> a complete conversion to cpu_dev style initialisation as done on 32bit, but that
> can easily be performed later after moving all the code out into its respective places.
> (downside: a bunch of externs in the interim).
>
> comments on this before I go any further?
>
Looks good to me at first glance, and would definitely be a good step on
the way.
-hpa
next prev parent reply other threads:[~2008-05-20 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 4:09 [X86] Remove unnecessary code in 64bit CPU identification Dave Jones
2008-05-20 4:14 ` Dave Jones
2008-05-20 14:46 ` H. Peter Anvin
2008-05-20 15:16 ` Dave Jones
2008-05-20 17:58 ` H. Peter Anvin
2008-05-20 18:06 ` Dave Jones
2008-05-20 19:18 ` Dave Jones
2008-05-20 19:42 ` H. Peter Anvin [this message]
2008-05-21 23:55 ` H. Peter Anvin
2008-05-22 14:04 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48332990.9030609@zytor.com \
--to=hpa@zytor.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox