From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760775AbYETTm7 (ORCPT ); Tue, 20 May 2008 15:42:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757458AbYETTmr (ORCPT ); Tue, 20 May 2008 15:42:47 -0400 Received: from terminus.zytor.com ([198.137.202.10]:43949 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757567AbYETTmq (ORCPT ); Tue, 20 May 2008 15:42:46 -0400 Message-ID: <48332990.9030609@zytor.com> Date: Tue, 20 May 2008 12:42:08 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Dave Jones , "H. Peter Anvin" , Linux Kernel , Ingo Molnar , Thomas Gleixner Subject: Re: [X86] Remove unnecessary code in 64bit CPU identification. References: <200805200409.m4K49ZuE024343@gelk.kernelslacker.org> <4832E461.2070503@zytor.com> <20080520151655.GA542@redhat.com> <4833112F.7020402@zytor.com> <20080520191812.GB31805@redhat.com> In-Reply-To: <20080520191812.GB31805@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Jones wrote: > > Moving along the same direction.. Moving the vendor specific bits out of setup_64.c > into cpu/ would go a long way towards killing of setup64.c. I took a first pass at doing this > in the diff below. So far I only looked at the AMD specific bits, and haven't done > a complete conversion to cpu_dev style initialisation as done on 32bit, but that > can easily be performed later after moving all the code out into its respective places. > (downside: a bunch of externs in the interim). > > comments on this before I go any further? > Looks good to me at first glance, and would definitely be a good step on the way. -hpa