From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935465AbYEUP2Q (ORCPT ); Wed, 21 May 2008 11:28:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935874AbYEUP1v (ORCPT ); Wed, 21 May 2008 11:27:51 -0400 Received: from cluster-g.mailcontrol.com ([85.115.41.190]:57349 "EHLO cluster-g.mailcontrol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935851AbYEUP1s (ORCPT ); Wed, 21 May 2008 11:27:48 -0400 Message-ID: <483431BE.7090707@csr.com> Date: Wed, 21 May 2008 15:29:18 +0100 From: David Vrabel User-Agent: Thunderbird 2.0.0.14 (X11/20080502) MIME-Version: 1.0 To: Alan Stern CC: Oliver Neukum , Jiri Kosina , Greg KH , linux-usb@vger.kernel.org, lchiquitto@novell.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: fix deadlock in HCD code References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 21 May 2008 14:29:17.0842 (UTC) FILETIME=[0D349720:01C8BB4F] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Stern wrote: > > The functions you are worried about (usb_hcd_link_urb_to_ep and > usb_hcd_unlink_urb_from_ep) are documented as requiring that interrupts > be disabled by their callers. This patch isn't needed. This requirement is the only reason the whci-hcd driver disables interrupts. Removing this requirement would reduce the time that interrupts are disabled in the whci-hcd driver. David -- David Vrabel, Senior Software Engineer, Drivers CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562 Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/