Re: [RFC] x86: merging nmi 32/64 to nmi.c v2

Cyrill Gorcunov
2008-05-23T03:33:38Z

[Thomas Gleixner - Thu, May 22, 2008 at 11:37:34PM +0200]
| On Wed, 21 May 2008, Cyrill Gorcunov wrote:
| >
| > Here is updated version (thanks Hiroshi) - I've moved these funcs
| > to traps_64.c and it's compiled just fine (so we are going closer
| > to merge someday even traps-32/64 ;)
|
| Cyrill,
|
| I really like that patch, but I'm a bit wary about the doit in one go
| approach. Its pretty hard to review that way and in case of breakage
| bisecting will just point to one large diff which is hard to decode.
|
| Can you please try to make this a more fine grained patch series ?
|
| Gradually add/modify the two files so they are identical at the
| end. There are a couple of obvious steps, e.g. the move of function to
| traps_*.c and adding the inline functions like get_timer_irqs().
|
| Thanks,
| tglx
|

Hi Thomas,

i think it was silly from my side to send such a *huge* patch at once,
but original idea was to get an overwiew of the change in general, that
is why I put changelog on top. So this patch (well RFC) was not to inclusion
but for review only ;) And even if you/Ingo have it applied to a tree it would
be totally undisectable anyway (as you pointed). So I will make quilt series
this weekend. Thanks a lot!

- Cyrill -