From: Arjan van de Ven <arjan@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] serial: fix enable_irq_wake/disable_irq_wake imbalance in serial_core.c
Date: Wed, 21 May 2008 20:59:37 -0700 [thread overview]
Message-ID: <4834EFA9.6050407@linux.intel.com> (raw)
In-Reply-To: <20080521145338.022abd3b.akpm@linux-foundation.org>
Andrew Morton wrote:
>> }
>>
>> - if (!port->suspended) {
>> + tty_dev = device_find_child(port->dev, &match, serial_match_port);
>> + if (!port->suspended && device_may_wakeup(tty_dev)) {
>> disable_irq_wake(port->irq);
>> mutex_unlock(&state->mutex);
>> return 0;
>
> erp, is that the easiest way of going from a uart_driver* to a device*?
> Doing a lookup each time is a bit unusual.
>
this is during suspend/resume only, so I figured it wasn't going to be that performance critical;
I wanted the code to be as symmetric as possible rather than fastest..
prev parent reply other threads:[~2008-05-22 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 3:11 [PATCH] serial: fix enable_irq_wake/disable_irq_wake imbalance in serial_core.c Arjan van de Ven
2008-05-21 21:53 ` Andrew Morton
2008-05-22 3:59 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4834EFA9.6050407@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox