From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752107AbYEVEPl (ORCPT ); Thu, 22 May 2008 00:15:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750739AbYEVEPd (ORCPT ); Thu, 22 May 2008 00:15:33 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:40058 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750718AbYEVEPc (ORCPT ); Thu, 22 May 2008 00:15:32 -0400 Message-ID: <4834F2E2.3070806@cs.helsinki.fi> Date: Thu, 22 May 2008 07:13:22 +0300 From: Pekka Enberg User-Agent: Thunderbird 2.0.0.14 (Macintosh/20080421) MIME-Version: 1.0 To: Paul Mundt , Pekka J Enberg , linux-kernel@vger.kernel.org, clameter@sgi.com, mpm@selenic.com, dhowells@redhat.com Subject: Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize() References: <20080521234555.GB32707@linux-sh.org> In-Reply-To: <20080521234555.GB32707@linux-sh.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Mundt wrote: > This series seems to work ok with all of SLAB/SLUB/SLOB when also > applying the kobjsize() patch. Without the kobjsize() patch in place, > SLAB and SLUB both work, while SLOB still triggers the >= MAX_ORDER > BUG_ON() for page cache pages. Note that this is still an improvement > over SLUB blowing up, as it was before, even without the kobjsize() > change. That's probably due to the fact that we use PageSlab for all pages with SLUB and for bigblock pages in SLOB with this patch. Christoph, Matt, any suggestions how to fix the PageSlab check in nommu btw? Pekka