Re: [PATCH -mm] remove node_ prefix_from ns subsystem

Andrew Morton
2008-05-22T07:34:08Z

On Thu, 22 May 2008 00:11:56 -0700 "Paul Menage" <menage@google.com> wrote:

> On Wed, May 21, 2008 at 10:06 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> >> --- 2.6.26-rc2-mm1.orig/kernel/cgroup.c
> >> +++ 2.6.26-rc2-mm1/kernel/cgroup.c
> >> @@ -2903,7 +2903,7 @@ int cgroup_clone(struct task_struct *tsk
> >> cg = tsk->cgroups;
> >> parent = task_cgroup(tsk, subsys->subsys_id);
> >>
> >> - snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "node_%d", tsk->pid);
> >> + snprintf(nodename, MAX_CGROUP_TYPE_NAMELEN, "%d", tsk->pid);
> >>
> >> /* Pin the hierarchy */
> >> atomic_inc(&parent->root->sb->s_active);
> >
> > This is user-visible, isn't it? Been there since October. How can we
> > safely change it now?
>
> It is user-visible, but I'd be extremely surprised if anyone was
> depending on it or even using it at this point.

After six months?

Oh well, I guess the number is small, and they'll know how to fix it.

What is the reason for making this change?