From: Emmanuel Colbus <emmanuel.colbus@ovh.net>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment
Date: Thu, 22 May 2008 10:08:26 +0200 [thread overview]
Message-ID: <483529FA.4030305@ovh.net> (raw)
In-Reply-To: <20080521185306.GA9320@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Emmanuel Colbus <emmanuel.colbus@ovh.net> :
>
>> Calling "PCI base addr 1" something that can actually lie at
>> PCI_BASE_ADDR_2 is misleading. Patch follows.
>>
>> signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
>>
>
> I do not approve:
> - the patch does not follow the comment style of the driver
> - the comment should be removed, not silly augmented
>
>
OK, makes sense. Second version :
This comment is misleading, since the region it refers to can actually
be PCI_BASE_ADDR_2. Remove it.
signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
---
diff -Naur drivers/net/r8169.c.old drivers/net/r8169.c
--- drivers/net/r8169.c.old 2008-05-22 09:55:51.000000000 +0200
+++ drivers/net/r8169.c 2008-05-22 09:55:59.000000000 +0200
@@ -1632,7 +1632,6 @@
if (rc < 0)
goto err_out_disable_2;
- /* make sure PCI base addr 1 is MMIO */
if (!(pci_resource_flags(pdev, region) & IORESOURCE_MEM)) {
if (netif_msg_probe(tp)) {
dev_err(&pdev->dev,
prev parent reply other threads:[~2008-05-22 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 14:08 [PATCH][TRIVIAL] r8169.c : fix misleading comment Emmanuel Colbus
2008-05-21 18:53 ` Francois Romieu
2008-05-22 8:08 ` Emmanuel Colbus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483529FA.4030305@ovh.net \
--to=emmanuel.colbus@ovh.net \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox