From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934350AbYEVIJi (ORCPT ); Thu, 22 May 2008 04:09:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761166AbYEVIJV (ORCPT ); Thu, 22 May 2008 04:09:21 -0400 Received: from smtpq2.tilbu1.nb.home.nl ([213.51.146.201]:49280 "EHLO smtpq2.tilbu1.nb.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760229AbYEVIJT (ORCPT ); Thu, 22 May 2008 04:09:19 -0400 Message-ID: <48352AC1.9000501@keyaccess.nl> Date: Thu, 22 May 2008 10:11:45 +0200 From: Rene Herman User-Agent: Thunderbird 2.0.0.14 (X11/20080421) MIME-Version: 1.0 To: Jaroslav Kysela CC: Jeff Garzik , Takashi Iwai , LKML , Linus Torvalds , ALSA development Subject: Re: Moving sound/* to drivers/ ? References: <4834B252.1080700@garzik.org> <4834B5E2.3040301@keyaccess.nl> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.0 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-05-08 08:26, Jaroslav Kysela wrote: > On Thu, 22 May 2008, Rene Herman wrote: >> From a structural view, the PCM core is just as much not a driver >> as the IP protocol isn't one and moving all of sound/ to drivers/ >> would trade the current "why are the drivers not under drivers/?" >> issue for a "why is all this non-driver code under drivers/?". >> >> This "net model" of sound/ and drivers/sound/ would be cleanest I >> feel. > > Yes, it was one reason why I used 'sound/' as root of the ALSA tree. > The second reason was to move old OSS tree to new directory to make > less confusion. And the third reason was to just keep ALSA directory > same as in our local development tree (which is out-of-kernel tree - > containing only ALSA parts). > > I feel that from the maintenance perspective, having one directory is > a plus. We have already 'drivers/usb/core', 'mmc/core', > 'drivers/base' (ALSA toplevel and midlevel modules use functions from > this tree) etc. Yes, examples of the same thing. drivers/base still sort of fits, but yes. Would the maintenance be really helped? As you said in another reply, the external tree already shuffles Documentation/sound/alsa and include/sound around anyway. I don't feel very strongly about it or anything but it's also a kernel statistics issue. Linus for example frequently announces new -rc's with "90% is in drivers" and such and if large(r) parts of drivers/ consist not of driver code that's a less useful metric. > If we have general consensus that sound drivers should go to back to > 'drivers/sound' then I would move all code. We can move 'sound/core' > tree to '/sound' in next round later... I'd expect that if you give up your nice top level directory you're not getting it back later... :-) Rene.