public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kentaro Makita <k-makita@np.css.fujitsu.com>
To: akpm@linux-foundation.org, dgc@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC]fix soft lock up at NFS mount by per-SB LRU-list of unused dentries
Date: Thu, 22 May 2008 17:20:42 +0900	[thread overview]
Message-ID: <48352CDA.2030603@np.css.fujitsu.com> (raw)
In-Reply-To: <20080521235510.22bff69f.akpm@linux-foundation.org>

Andrew Morton wrote:
> On Thu, 22 May 2008 11:22:18 +0900 Kentaro Makita <k-makita@np.css.fujitsu.com> wrote:
> 
>> [Summary]
>>   Split LRU-list of unused dentries to each superblocks to avoid soft lock up
>>  at NFS mounts and remounting any filesystem.
>>
>>  Previosly I posted are:
>>  http://lkml.org/lkml/2008/3/5/590
>>
>> [Descriptions]
>> - background
>>  dentry_unused is a list of dentries which is not in use. This works
>>  as a cache against not-exisiting files. dentry_unused grows up when
>>  directories or files are removed. This list can be very long if
>>  there is huge free memory.
> 
> The dentry_unused inodes are not actually not-existing files.  They are
> dentries which refer to live files (and, iirc, negative dentries) but
> which nobody is actually using - for example, regular files which
> nobody currently has open.
> 
> I changed the changelog text to reflect that.
Oh, Thank you for your good information and fixing.
> 
>> - what's problem
>>
>>  This patch is against linux-2.6.26-rc3. Tested on x86_64.
> 
> Looks good to me, thanks.  And no, the loss of the strict global LRU
> handling of the dentry LRU is unlikely to be an issue.
> 
>> Based on David Chinner's "Per-superblock unused dentry LRU lists V3".
>> ...
>> Signed-off-by: Kentaro Makita <k-makita@np.css.fujitsu.com>
> 
> I guess we should ask David for his signed-off-by: on this.
Thank you for your works too, David.

Best Regards,
Kentaro Makita


  reply	other threads:[~2008-05-22  8:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22  2:22 [PATCH][RFC]fix soft lock up at NFS mount by per-SB LRU-list of unused dentries Kentaro Makita
2008-05-22  6:55 ` Andrew Morton
2008-05-22  8:20   ` Kentaro Makita [this message]
2008-05-22 22:56 ` David Chinner
2008-05-22 23:14   ` Harvey Harrison
2008-05-23  2:15   ` Kentaro Makita
2008-05-23  4:22     ` David Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48352CDA.2030603@np.css.fujitsu.com \
    --to=k-makita@np.css.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=dgc@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox