From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbcJKKYD (ORCPT ); Tue, 11 Oct 2016 06:24:03 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36400 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbcJKKYB (ORCPT ); Tue, 11 Oct 2016 06:24:01 -0400 Subject: Re: [RESEND PATCH v6, 4/5] usb: Add MediaTek USB3 DRD Driver To: Chunfeng Yun References: <1474437277-27201-1-git-send-email-chunfeng.yun@mediatek.com> <1474437277-27201-5-git-send-email-chunfeng.yun@mediatek.com> <49293f1b-42b5-f06b-8fdc-f46fe996e237@gmail.com> <1476155663.15546.32.camel@mhfsdcap03> Cc: Greg Kroah-Hartman , Felipe Balbi , Mathias Nyman , Oliver Neukum , Alan Stern , Rob Herring , Mark Rutland , Ian Campbell , Sergei Shtylyov , Pawel Moll , Kumar Gala , Sascha Hauer , Alan Cooper , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org From: Matthias Brugger Message-ID: <48357a7f-deee-b114-ccd4-914fd5fa400f@gmail.com> Date: Tue, 11 Oct 2016 12:23:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476155663.15546.32.camel@mhfsdcap03> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2016 05:14 AM, Chunfeng Yun wrote: > On Mon, 2016-10-10 at 13:00 +0200, Matthias Brugger wrote: >> >> On 09/21/2016 07:54 AM, Chunfeng Yun wrote: >>> This patch adds support for the MediaTek USB3 controller >>> integrated into MT8173. It can be configured as Dual-Role >>> Device (DRD), Peripheral Only and Host Only (xHCI) modes. >>> >>> Signed-off-by: Chunfeng Yun >>> --- >>> drivers/usb/Kconfig | 2 + >>> drivers/usb/Makefile | 1 + >>> drivers/usb/mtu3/Kconfig | 54 +++ >>> drivers/usb/mtu3/Makefile | 19 + >>> drivers/usb/mtu3/mtu3.h | 422 +++++++++++++++++ >>> drivers/usb/mtu3/mtu3_core.c | 871 +++++++++++++++++++++++++++++++++++ >>> drivers/usb/mtu3/mtu3_dr.c | 379 ++++++++++++++++ >>> drivers/usb/mtu3/mtu3_dr.h | 108 +++++ >>> drivers/usb/mtu3/mtu3_gadget.c | 731 +++++++++++++++++++++++++++++ >>> drivers/usb/mtu3/mtu3_gadget_ep0.c | 883 ++++++++++++++++++++++++++++++++++++ >>> drivers/usb/mtu3/mtu3_host.c | 294 ++++++++++++ >>> drivers/usb/mtu3/mtu3_hw_regs.h | 473 +++++++++++++++++++ >>> drivers/usb/mtu3/mtu3_plat.c | 490 ++++++++++++++++++++ >>> drivers/usb/mtu3/mtu3_qmu.c | 599 ++++++++++++++++++++++++ >>> drivers/usb/mtu3/mtu3_qmu.h | 43 ++ >>> 15 files changed, 5369 insertions(+) >>> create mode 100644 drivers/usb/mtu3/Kconfig >>> create mode 100644 drivers/usb/mtu3/Makefile >>> create mode 100644 drivers/usb/mtu3/mtu3.h >>> create mode 100644 drivers/usb/mtu3/mtu3_core.c >>> create mode 100644 drivers/usb/mtu3/mtu3_dr.c >>> create mode 100644 drivers/usb/mtu3/mtu3_dr.h >>> create mode 100644 drivers/usb/mtu3/mtu3_gadget.c >>> create mode 100644 drivers/usb/mtu3/mtu3_gadget_ep0.c >>> create mode 100644 drivers/usb/mtu3/mtu3_host.c >>> create mode 100644 drivers/usb/mtu3/mtu3_hw_regs.h >>> create mode 100644 drivers/usb/mtu3/mtu3_plat.c >>> create mode 100644 drivers/usb/mtu3/mtu3_qmu.c >>> create mode 100644 drivers/usb/mtu3/mtu3_qmu.h >>> >> >> As Oliver already said, this patch is quiet big which makes it difficult >> to review. >> I propose to provide a first implementation with minimal functionality >> and incremental patches on top of this when the first got merged. >> >> You could split the patch in three series/parts: >> 1. Host only >> 2. Peripheral only >> 3. Dual mode >> >> What do you think? > > Ok, I'll split the patch into some small ones as many as possible. There is no direct policy how to do that and it depends a bit on every maintainer what he prefers. As a rule of thumb each commit should compile on it's own without errors. This makes bisecting the kernel much easier. Regards, Matthias > > Thanks a lot >> >> Regards, >> Matthias >> > >