From: Dave Jiang <djiang@mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: dougthompson@xmission.com, Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, bluesmoke-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] edac: mpc85xx - Fix building as a module
Date: Thu, 22 May 2008 09:13:10 -0700 [thread overview]
Message-ID: <48359B96.2020303@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805212326000.32442@blarg.am.freescale.net>
Acked-by: Dave Jiang <djiang@mvista.com>
Kumar Gala wrote:
> including of <asm/mpc85xx.h> causes build problems since it doesn't exist.
>
> Also removed warning:
> drivers/edac/mpc85xx_edac.c:45: warning: 'mpc85xx_ctl_name' defined but not used
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>
> This is a fix for 2.6.26.
>
> - k
>
> drivers/edac/mpc85xx_edac.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 065732d..d49361b 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -20,7 +20,6 @@
>
> #include <linux/of_platform.h>
> #include <linux/of_device.h>
> -#include <asm/mpc85xx.h>
> #include "edac_module.h"
> #include "edac_core.h"
> #include "mpc85xx_edac.h"
> @@ -43,8 +42,6 @@ static u32 orig_pci_err_en;
> static u32 orig_l2_err_disable;
> static u32 orig_hid1;
>
> -static const char *mpc85xx_ctl_name = "MPC85xx";
> -
> /************************ MC SYSFS parts ***********************************/
>
> static ssize_t mpc85xx_mc_inject_data_hi_show(struct mem_ctl_info *mci,
--
------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------
prev parent reply other threads:[~2008-05-22 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 4:26 [PATCH] edac: mpc85xx - Fix building as a module Kumar Gala
2008-05-22 16:13 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48359B96.2020303@mvista.com \
--to=djiang@mvista.com \
--cc=akpm@osdl.org \
--cc=bluesmoke-devel@lists.sourceforge.net \
--cc=dougthompson@xmission.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox