From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757553AbYEVTYm (ORCPT ); Thu, 22 May 2008 15:24:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754027AbYEVTY3 (ORCPT ); Thu, 22 May 2008 15:24:29 -0400 Received: from stinky.trash.net ([213.144.137.162]:44895 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbYEVTY2 (ORCPT ); Thu, 22 May 2008 15:24:28 -0400 Message-ID: <4835C806.6020408@trash.net> Date: Thu, 22 May 2008 21:22:46 +0200 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.12 (X11/20080420) MIME-Version: 1.0 To: Pekka J Enberg CC: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mpm@selenic.com, clameter@sgi.com Subject: Re: [PATCH] netfilter: use krealloc() in nf_conntrack_extend.c V2 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pekka J Enberg wrote: > To: kaber@trash.net > [PATCH] netfilter: use krealloc() in nf_conntrack_extend.c V2 > From: Pekka Enberg > > The ksize() API is going away because it is being abused and it doesn't even > work consistenly across different allocators. Therefore, convert > net/netfilter/nf_conntrack_extend.c to use krealloc(). > > Cc: > Cc: > Cc: Matt Mackall > Cc: Christoph Lameter > Signed-off-by: Pekka Enberg > --- > Patrick, please use this patch instead. The previous one did the moving > unconditionally which is wrong. This one moves entries around only if > krealloc() allocated a new buffer. Applied, thanks.