Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo Yoga Slim 7 Pro 14ARH7 82UU

Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo Yoga Slim 7 Pro 14ARH7 82UU

[Linux regression tracking (Thorsten Leemhuis)]

On 02.10.23 23:04, Markus Meier wrote:
> 
> I own a  Lenovo Yoga Slim 7 Pro 14ARH7 where the microphone is not showing up.
> I added the system to the quirk table and the mic is working correctly (but 
> with very low volume) now.
> 
> Here's an except from dmidecode:
> System Information
>         Manufacturer: LENOVO
>         Product Name: 82UU
>         Version: Yoga Slim 7 Pro 14ARH7
>         SKU Number: LENOVO_MT_82UU_BU_idea_FM_Yoga Slim 7 Pro 14ARH7
>         Family: Yoga Slim 7 Pro 14ARH7
>
> Please add this patch to the kernel and add it to the stable kernels too. I 
> guess the microphone should have worked before. Seems to be a regression 
> introduced by c008323fe361bd62a43d9fb29737dacd5c067fb7
>
> [-- Attachment #2: yoga-slim-7-pro-82UU-microphone.patch --]
> [-- Type: text/x-patch, Size: 451 bytes --]
> 
> --- a/sound/soc/amd/yc/acp6x-mach.c	2023-09-29 19:31:03.753786095 +0200
> +++ b/sound/soc/amd/yc/acp6x-mach.c	2023-09-29 19:32:06.414276453 +0200
> @@ -217,6 +217,13 @@
>  		.driver_data = &acp6x_card,
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82UU"),
> +		}
> +	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
>  		}
>  	},

I CCed a bunch of lists and people to make sure everyone is aware of
that patch, as it otherwise might fall through the cracks.

Markus, quick question: do you have (a) an interest in contributing a
change to Linux or (b) did you just post this because Mario asked you to
do so in https://bugzilla.kernel.org/show_bug.cgi?id=217063#c25 ?

If it's (a) then you might want to take a closer look at
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
, as your patch lacks a few important things before it can be applied
(most notably a Signed-off-by tag)

If it's (b) I wonder if it would be easier for everyone involved if some
kernel developer could create a patch own their own, as that likely is
way easier to review and thus likely gets the problem resolved a lot faster.

Ciao, Thorsten

Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo Yoga Slim 7 Pro 14ARH7 82UU

[Markus Meier]

[-- Attachment #1: Type: text/plain, Size: 3027 bytes --]

Am Dienstag, 3. Oktober 2023, 12:24:56 CEST schrieben Sie:
> On 02.10.23 23:04, Markus Meier wrote:
> > I own a  Lenovo Yoga Slim 7 Pro 14ARH7 where the microphone is not showing
> > up. I added the system to the quirk table and the mic is working
> > correctly (but with very low volume) now.
> > 
> > Here's an except from dmidecode:
> > System Information
> > 
> >         Manufacturer: LENOVO
> >         Product Name: 82UU
> >         Version: Yoga Slim 7 Pro 14ARH7
> >         SKU Number: LENOVO_MT_82UU_BU_idea_FM_Yoga Slim 7 Pro 14ARH7
> >         Family: Yoga Slim 7 Pro 14ARH7
> > 
> > Please add this patch to the kernel and add it to the stable kernels too.
> > I
> > guess the microphone should have worked before. Seems to be a regression
> > introduced by c008323fe361bd62a43d9fb29737dacd5c067fb7
> > 
> > [-- Attachment #2: yoga-slim-7-pro-82UU-microphone.patch --]
> > [-- Type: text/x-patch, Size: 451 bytes --]
> > 
> > --- a/sound/soc/amd/yc/acp6x-mach.c	2023-09-29 19:31:03.753786095 
+0200
> > +++ b/sound/soc/amd/yc/acp6x-mach.c	2023-09-29 19:32:06.414276453 
+0200
> > @@ -217,6 +217,13 @@
> > 
> >  		.driver_data = &acp6x_card,
> >  		.matches = {
> >  		
> >  			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> > 
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "82UU"),
> > +		}
> > +	},
> > +	{
> > +		.driver_data = &acp6x_card,
> > +		.matches = {
> > +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> > 
> >  			DMI_MATCH(DMI_PRODUCT_NAME, "82V2"),
> >  		
> >  		}
> >  	
> >  	},
> 
> I CCed a bunch of lists and people to make sure everyone is aware of
> that patch, as it otherwise might fall through the cracks.
> 
> Markus, quick question: do you have (a) an interest in contributing a
> change to Linux or (b) did you just post this because Mario asked you to
> do so in https://bugzilla.kernel.org/show_bug.cgi?id=217063#c25 ?

Nope I don't plan to become some kind of kernel developer. I just want to use 
my notebook without any issues and want to help others who want to use this 
device with Linux too. I just followed Mario's suggestions. I thought it would 
be easier for everyone when I create a patch, try if it works and then submit 
it to a bugtracker to get the bug fixed.

> If it's (a) then you might want to take a closer look at
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> , as your patch lacks a few important things before it can be applied
> (most notably a Signed-off-by tag)
> 
> If it's (b) I wonder if it would be easier for everyone involved if some
> kernel developer could create a patch own their own, as that likely is
> way easier to review and thus likely gets the problem resolved a lot faster.

Please feel free to create a patch based on mine, when it's easier and faster 
that way. I don't really care as long as the microphone is working in one of 
the next kernel releases. 

Thanks for your help Thorsten. I really enjoyed your Heise Kernel-Log series 
and I really miss those series. Was always a pleasure to read that.

Kind regards
Markus


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: amd: yc: Fix non-functional mic on Lenovo Yoga Slim 7 Pro 14ARH7 82UU

[Linux regression tracking (Thorsten Leemhuis)]

On 03.10.23 17:04, Markus Meier wrote:
> Am Dienstag, 3. Oktober 2023, 12:24:56 CEST schrieben Sie:
>> On 02.10.23 23:04, Markus Meier wrote:
>>> I own a  Lenovo Yoga Slim 7 Pro 14ARH7 where the microphone is not showing
>>> up. I added the system to the quirk table and the mic is working
>>> correctly (but with very low volume) now.
> [...]
>> I CCed a bunch of lists and people to make sure everyone is aware of
>> that patch, as it otherwise might fall through the cracks.
>>
>> Markus, quick question: do you have (a) an interest in contributing a
>> change to Linux or (b) did you just post this because Mario asked you to
>> do so in https://bugzilla.kernel.org/show_bug.cgi?id=217063#c25 ?
> 
> Nope I don't plan to become some kind of kernel developer. I just want to use 
> my notebook without any issues and want to help others who want to use this 
> device with Linux too. I just followed Mario's suggestions. I thought it would 
> be easier for everyone when I create a patch, try if it works and then submit 
> it to a bugtracker to get the bug fixed.

And that's good, as that way we know that the fix works, so many thx for
it. It's just that the patch description needs to be more like the
following.

"""
The 82UU (Lenovo Yoga Slim 7 Pro 14ARH7) requires an entry in the quirk
list to enable the internal microphone, just like many other Lenovo 82*
devices recently added.

Fixes: c008323fe361 ("ASoC: amd: yc: Fix a non-functional mic on Lenovo
82SJ")
Cc: stable@vger.kernel.org
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217063#c23
"""

Add another line right below with your sign-off, as explained here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Then send it again. The patch likely must be inline (but maybe Mark
accepts attached patches as well, not sure, some maintainers do).

If you want the easy way out, just reply to your mail that started this
thread (with me in CC) with a signed-off-by tag for the patch, then I'll
handle the rest.

> [...]
> Thanks for your help Thorsten. I really enjoyed your Heise Kernel-Log series 
> and I really miss those series. Was always a pleasure to read that.

Thx, great to hear!

Ciao, Thorsten