[PATCH 0/2] ACPI: add "OSI(Linux) checking procedure" for ia64 machines

[PATCH 0/2] ACPI: add "OSI(Linux) checking procedure" for ia64 machines

[Taku Izumi]

Hi all,

Currently there is no "OSI(Linux) checking procedure" on ia64,
so it is no use adding ia64 machines' entry to the acpi_osi_dmi_table
for the purpose of enabling or disabling OSI(Linux).

The following first patch adds acpi_osi_dmi_table evaluation procedure
for ia64 machines. The second patch adds our ia64 machine's entry to
its table, because we want to enable OSI(Linux) on our mahines.

* [PATCH 1/2] ACPI: add acpi_osi_dmi_table evaluation procedure for ia64 
machines
* [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

Best regards,
Taku Izumi <izumi.taku@jp.fujitsu.com>

[PATCH 1/2] ACPI: add acpi_osi_dmi_table evaluation procedure for ia64 machines

[Taku Izumi]

Currently, acpi_osi_dmi_table is valid only for x86 machines.
This patch makes its table valid for ia64 machines too and adds
evaluation procedure for the purpose of checking if OSI(Linux)
should be enabled or not.

Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>

---
  arch/ia64/kernel/setup.c |    7 +++++++
  drivers/acpi/Makefile    |    1 +
  2 files changed, 8 insertions(+)

Index: linux-2.6.25.4/arch/ia64/kernel/setup.c
===================================================================
--- linux-2.6.25.4.orig/arch/ia64/kernel/setup.c
+++ linux-2.6.25.4/arch/ia64/kernel/setup.c
@@ -985,3 +985,10 @@ static int __init run_dmi_scan(void)
  	return 0;
  }
  core_initcall(run_dmi_scan);
+
+static int __init invoke_acpi_blacklisted(void)
+{
+	acpi_blacklisted();
+	return 0;
+}
+postcore_initcall(invoke_acpi_blacklisted);
Index: linux-2.6.25.4/drivers/acpi/Makefile
===================================================================
--- linux-2.6.25.4.orig/drivers/acpi/Makefile
+++ linux-2.6.25.4/drivers/acpi/Makefile
@@ -17,6 +17,7 @@ EXTRA_CFLAGS	+= $(ACPI_CFLAGS)
  #
  obj-y				+= tables.o
  obj-$(CONFIG_X86)		+= blacklist.o
+obj-$(CONFIG_IA64)		+= blacklist.o

  #
  # ACPI Core Subsystem (Interpreter)

[PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Taku Izumi]

This patch adds DMI info to enable OSI(Linux) on PRIMEQUEST.
(PRIMEQUEST is ia64 machine.)

Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>

---
  drivers/acpi/blacklist.c |   14 ++++++++++++++
  1 file changed, 14 insertions(+)

Index: linux-2.6.25.4/drivers/acpi/blacklist.c
===================================================================
--- linux-2.6.25.4.orig/drivers/acpi/blacklist.c
+++ linux-2.6.25.4/drivers/acpi/blacklist.c
@@ -626,6 +626,20 @@ static struct dmi_system_id acpi_osi_dmi
  		     DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
  		},
  	},
+	/*
+	 * Enable OSI(Linux) on Fujitsu PRIMEQUEST
+	 *
+	 * DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
+	 *
+	 */
+	{
+	.callback = dmi_enable_osi_linux,
+	.ident = "Fujitsu PRIMEQUEST",
+	.matches = {
+		     DMI_MATCH(DMI_BIOS_VENDOR, "FUJITSU LIMITED"),
+		     DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
+		},
+	},
  	{}
  };

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Pavel Machek]

On Fri 2008-05-23 15:43:48, Taku Izumi wrote:
> This patch adds DMI info to enable OSI(Linux) on 
> PRIMEQUEST.
> (PRIMEQUEST is ia64 machine.)

Why is it needed? Why needs your bios know whether it is Linux or BSD
or whatver running?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Taku Izumi]

Thank you for your response.

>> This patch adds DMI info to enable OSI(Linux) on 
>> PRIMEQUEST.
>> (PRIMEQUEST is ia64 machine.)
> 
> Why is it needed? Why needs your bios know whether it is Linux or BSD
> or whatver running?

   For memory hotplug support.
   Memory hotplug doesn't work on PRIMEQUEST when OSI(Linux) is disabled.

Best regards,
Taku Izumi <izumi.taku@jp.fujitsu.com>

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Pavel Machek]

On Mon 2008-05-26 16:56:05, Taku Izumi wrote:
>
> Thank you for your response.
>
>>> This patch adds DMI info to enable OSI(Linux) on PRIMEQUEST.
>>> (PRIMEQUEST is ia64 machine.)
>>
>> Why is it needed? Why needs your bios know whether it is Linux or BSD
>> or whatver running?
>
>   For memory hotplug support.
>   Memory hotplug doesn't work on PRIMEQUEST when OSI(Linux) is disabled.

So fix the BIOS: there's no reason why memory hotplug should not work
on BSD or Windows...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[KAMEZAWA Hiroyuki]

On Mon, 26 May 2008 10:06:14 +0200
Pavel Machek <pavel@suse.cz> wrote:

> On Mon 2008-05-26 16:56:05, Taku Izumi wrote:
> >
> > Thank you for your response.
> >
> >>> This patch adds DMI info to enable OSI(Linux) on PRIMEQUEST.
> >>> (PRIMEQUEST is ia64 machine.)
> >>
> >> Why is it needed? Why needs your bios know whether it is Linux or BSD
> >> or whatver running?
> >
> >   For memory hotplug support.
> >   Memory hotplug doesn't work on PRIMEQUEST when OSI(Linux) is disabled.
> 
> So fix the BIOS: there's no reason why memory hotplug should not work
> on BSD or Windows...
> 									Pavel
IIRC, PrimeQuest doesn't support BSD ;)

It's not really for memory hotplug. The result of _OSI method (TOOS) is
used for PCI, EC driver's behavior, etc.. (on my box) 

BTW, PrimeQuest's firmware is designed in 2.6.18 age and _heavily_ tested under
_OSI("Linux") environments. So, the acpi layer which returns _OSI("Linux") 
is valid for PrimeQuest. I don't hear a major firmware update for
already-sold-hosts is scheduled.

Thanks,
-Kame

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Arjan van de Ven]

On Tue, 27 May 2008 10:13:02 +0900
> BTW, PrimeQuest's firmware is designed in 2.6.18 age and _heavily_
> tested under _OSI("Linux") environments. So, the acpi layer which
> returns _OSI("Linux") is valid for PrimeQuest. I don't hear a major
> firmware update for already-sold-hosts is scheduled.
> 
the problem really is that 2.6.18 isn't 2.6.25. OSI("Linux") is really
the wrong thing to do!
Not even microsoft does that.. they have very version specific OSI
strings.

Can you work with your colleges in the BIOS team to make sure that no
future BIOS will use OSI("Linux") please? If there's something they
would want to disable because of a Linux bug.. the real solution is to
fix the Linux bug!

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Andrew Morton]

On Fri, 23 May 2008 15:43:48 +0900
Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:

> This patch adds DMI info to enable OSI(Linux) on PRIMEQUEST.
> (PRIMEQUEST is ia64 machine.)
> 
> Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
> 
> ---
>   drivers/acpi/blacklist.c |   14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> Index: linux-2.6.25.4/drivers/acpi/blacklist.c
> ===================================================================
> --- linux-2.6.25.4.orig/drivers/acpi/blacklist.c
> +++ linux-2.6.25.4/drivers/acpi/blacklist.c
> @@ -626,6 +626,20 @@ static struct dmi_system_id acpi_osi_dmi
>   		     DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
>   		},
>   	},
> +	/*
> +	 * Enable OSI(Linux) on Fujitsu PRIMEQUEST
> +	 *
> +	 * DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
> +	 *
> +	 */
> +	{
> +	.callback = dmi_enable_osi_linux,
> +	.ident = "Fujitsu PRIMEQUEST",
> +	.matches = {
> +		     DMI_MATCH(DMI_BIOS_VENDOR, "FUJITSU LIMITED"),
> +		     DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
> +		},
> +	},
>   	{}
>   };

It is unclear (to me) what the impact of this patch is.  Does it fix a
problem which would justify including these patches in 2.6.26?

Also, your email client is performing space-stuffing.  That is easy
enough to repair at this end (s/^ / /) but please do sort that out for
next time.  http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
should help.

Thanks.

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Tony Luck]

I'm not sure that sharing drivers/acpi/blacklist.c between different
architectures is wise idea.  There are entries in there that make
blanket decisions for all machines made by an OEM.

It seems quite possible that an OEM that makes boxes using
different processor architectures might make different mistakes
in the respective BIOS teams.

-Tony

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Andrew Morton]

On Tue, 27 May 2008 16:41:59 -0700
"Tony Luck" <tony.luck@intel.com> wrote:

> I'm not sure that sharing drivers/acpi/blacklist.c between different
> architectures is wise idea.  There are entries in there that make
> blanket decisions for all machines made by an OEM.
> 
> It seems quite possible that an OEM that makes boxes using
> different processor architectures might make different mistakes
> in the respective BIOS teams.
> 

So...  what's the fix?  We don't appear to have a blacklisting table
under arch/ia64.  Should `#ifdef CONFIG_IA64' be added to
drivers/acpi/blacklist.c entries?

Re: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[KAMEZAWA Hiroyuki]

On Tue, 27 May 2008 16:20:29 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 23 May 2008 15:43:48 +0900
> Taku Izumi <izumi.taku@jp.fujitsu.com> wrote:
> 
> > This patch adds DMI info to enable OSI(Linux) on PRIMEQUEST.
> > (PRIMEQUEST is ia64 machine.)
> > 
> > Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
> > 
> > ---
> >   drivers/acpi/blacklist.c |   14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> > 
> > Index: linux-2.6.25.4/drivers/acpi/blacklist.c
> > ===================================================================
> > --- linux-2.6.25.4.orig/drivers/acpi/blacklist.c
> > +++ linux-2.6.25.4/drivers/acpi/blacklist.c
> > @@ -626,6 +626,20 @@ static struct dmi_system_id acpi_osi_dmi
> >   		     DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> >   		},
> >   	},
> > +	/*
> > +	 * Enable OSI(Linux) on Fujitsu PRIMEQUEST
> > +	 *
> > +	 * DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
> > +	 *
> > +	 */
> > +	{
> > +	.callback = dmi_enable_osi_linux,
> > +	.ident = "Fujitsu PRIMEQUEST",
> > +	.matches = {
> > +		     DMI_MATCH(DMI_BIOS_VENDOR, "FUJITSU LIMITED"),
> > +		     DMI_MATCH(DMI_BIOS_VERSION, "PRIMEQUEST"),
> > +		},
> > +	},
> >   	{}
> >   };
> 
> It is unclear (to me) what the impact of this patch is.  Does it fix a
> problem which would justify including these patches in 2.6.26?
> 
Ah, sorry. I think this is not 2.6.26 candidates.

  Before patch.
    - PrimeQuest doesn't work well without acpi_osi="Linux" boot option.
  After patch
    - PrimeQuest works well without boot option.

But Pavel Machek and Arjan van de Ven informed us that "Supporting OSI("Linux")
on PrimeQuest will be harmful even if it works well now. Because we cannot
guarantee compatibility of this interface in future". So, we're now discussing
the problem with our firmware team.

So, please ignore this patch for a while. We'll repost if necessary.

Thank you.

Regards.
-Kame

RE: [PATCH 2/2] ACPI: add DMI info to enable OSI(Linux) on PRIMEQUEST

[Luck, Tony]

> So...  what's the fix?  We don't appear to have a blacklisting table
> under arch/ia64.  Should `#ifdef CONFIG_IA64' be added to
> drivers/acpi/blacklist.c entries?

That sounds reasonable.  We should also put #if defined(CONFIG_X86)
around all the existing entries in the acpi_osi_dmi_table[].

-Tony