From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757397AbYEWIOe (ORCPT ); Fri, 23 May 2008 04:14:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754794AbYEWIOS (ORCPT ); Fri, 23 May 2008 04:14:18 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:56901 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754584AbYEWIOQ (ORCPT ); Fri, 23 May 2008 04:14:16 -0400 Message-ID: <48367D4D.8070802@sgi.com> Date: Fri, 23 May 2008 18:16:13 +1000 From: Lachlan McIlroy Reply-To: lachlan@sgi.com User-Agent: Thunderbird 2.0.0.14 (X11/20080421) MIME-Version: 1.0 To: Christoph Hellwig CC: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, akpm@linux-foundation.org Subject: Re: [GIT PULL] XFS update for 2.6.26-rc4 References: <20080523075846.F1ECF58C4C29@chook.melbourne.sgi.com> <20080523080318.GA19078@infradead.org> In-Reply-To: <20080523080318.GA19078@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bugger! I thought there was another one. Just sent another revised pull request. Christoph Hellwig wrote: > This is missing the page locking fix in xfs_buf.c which causes > regressions for people out there. > > On Fri, May 23, 2008 at 05:58:46PM +1000, Lachlan McIlroy wrote: >> Please pull from the for-linus branch: >> git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus >> >> This will update the following files: >> >> fs/xfs/linux-2.6/xfs_file.c | 17 ++++-- >> fs/xfs/linux-2.6/xfs_vnode.h | 8 --- >> fs/xfs/xfs_inode.c | 9 ++-- >> fs/xfs/xfs_vnodeops.c | 112 ++++++++++++++++-------------------------- >> fs/xfs/xfs_vnodeops.h | 3 +- >> 5 files changed, 59 insertions(+), 90 deletions(-) >> >> through these commits: >> >> commit c8f5f12e46f079a954d4f7163ba59dadee08ca26 >> Author: David Chinner >> Date: Tue May 20 11:30:15 2008 +1000 >> >> [XFS] Fix inode list allocation size in writeback. >> >> We only need to allocate space for the number of inodes in the cluster >> when writing back inodes, not every byte in the inode cluster. This >> reduces the amount of memory needing to be allocated to 256 bytes instead >> of 64k. >> >> SGI-PV: 981949 >> SGI-Modid: xfs-linux-melb:xfs-kern:31182a >> >> Signed-off-by: David Chinner >> Signed-off-by: Christoph Hellwig >> Signed-off-by: Lachlan McIlroy >> >> commit 49383b0e98ad1f69ff4c816eb1961f703df12318 >> Author: David Chinner >> Date: Mon May 19 16:29:34 2008 +1000 >> >> [XFS] Don't allow memory reclaim to wait on the filesystem in inode >> writeback >> >> If we allow memory reclaim to wait on the pages under writeback in inode >> cluster writeback we could deadlock because we are currently holding the >> ILOCK on the initial writeback inode which is needed in data I/O >> completion to change the file size or do unwritten extent conversion >> before the pages are taken out of writeback state. >> >> SGI-PV: 981091 >> SGI-Modid: xfs-linux-melb:xfs-kern:31015a >> >> Signed-off-by: David Chinner >> Signed-off-by: Christoph Hellwig >> Signed-off-by: Lachlan McIlroy >> >> commit 978b7237123d007b9fa983af6e0e2fa8f97f9934 >> Author: David Chinner >> Date: Mon May 19 16:29:46 2008 +1000 >> >> [XFS] Fix fsync() b0rkage. >> >> xfs_fsync() fails to wait for data I/O completion before checking if the >> inode is dirty or clean to decide whether to log the inode or not. This >> misses inode size updates when the data flushed by the fsync() is >> extending the file. >> >> Hence, like fdatasync(), we need to wait for I/o completion first, then >> check the inode for cleanliness. Doing so makes the behaviour of >> xfs_fsync() identical for fsync and fdatasync and we *always* use >> synchronous semantics if the inode is dirty. Therefore also kill the >> differences and remove the unused flags from the xfs_fsync function and >> callers. >> >> SGI-PV: 981296 >> SGI-Modid: xfs-linux-melb:xfs-kern:31033a >> >> Signed-off-by: David Chinner >> Signed-off-by: Christoph Hellwig >> Signed-off-by: Lachlan McIlroy >> >> > ---end quoted text--- > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >