From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761837AbYEXUjR (ORCPT ); Sat, 24 May 2008 16:39:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759352AbYEXUjG (ORCPT ); Sat, 24 May 2008 16:39:06 -0400 Received: from gw.goop.org ([64.81.55.164]:48041 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754146AbYEXUjE (ORCPT ); Sat, 24 May 2008 16:39:04 -0400 Message-ID: <48387CCB.1030801@goop.org> Date: Sat, 24 May 2008 21:38:35 +0100 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Tom Spink CC: Vegard Nossum , Sam Ravnborg , "H. Peter Anvin" , Steve French , lkml Subject: Re: kernel coding style for if ... else which cross #ifdef References: <524f69650805231211r315be4e4u5890aa0f914bcb4f@mail.gmail.com> <4837AAE2.9090102@zytor.com> <20080524064201.GA4133@uranus.ravnborg.org> <4837E89D.9040008@goop.org> <20080524112704.GA7292@uranus.ravnborg.org> <483827CE.9080200@goop.org> <20080524153611.GA13890@uranus.ravnborg.org> <48383830.6060504@goop.org> <19f34abd0805240857l57e667fdicb240baf898f6296@mail.gmail.com> <48383C26.5040106@goop.org> <7b9198260805240940v46db928ak9bcacf9363c46d41@mail.gmail.com> In-Reply-To: <7b9198260805240940v46db928ak9bcacf9363c46d41@mail.gmail.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tom Spink wrote: > A thought occurred to me that we may be able to used some preprocessor > magic and do this: > > #define config_defined(x) CFGVAL_## x > > Which means that, if we get Kconfig to produce: > > #define CFGVAL_CONFIG_FOO 0 > #define CFGVAL_CONFIG_VALUE_BAR 1 > #define CFGVAL_CONFIG_VALUE_BAZ_MODULE 1 > > We can use this: > > if (config_defined(CONFIG_FOO) && some_expr) { > panic("Oh no."); > } Well, in that case you could use Willy's magic hack: #define config_defined(x) (x - 0) Which isn't a bad alternative to defining a whole pile of new symbols... J