From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Tom Spink <tspink@gmail.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Steve French <smfrench@gmail.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: kernel coding style for if ... else which cross #ifdef
Date: Sat, 24 May 2008 22:15:11 +0100 [thread overview]
Message-ID: <4838855F.2090701@goop.org> (raw)
In-Reply-To: <48388097.3060707@zytor.com>
H. Peter Anvin wrote:
> That's a very defeatist stance, and quite frankly bogus.
But <stamp foot> coding is *hard*.
> Doing it as a flag day event is not really practical, which is why we
> need a new set of symbols. However, at that point we can discourage
> continuing use of the CONFIG_ symbols and deprecate them over time.
> It's not like we're talking about user-space-visible interfaces here!
Well, I'm thinking more along the lines of:
1. We introduce this <whatever> mechanism
2. Hundreds of people pop out of the woodwork thinking "this looks
more fun than tweaking whitespace"
3. They produce one-hundred trillion "convert #ifdef to if()" patches
4. We have one-hundred trillion^2 followup "fix build with this
.config" patches
3 might be enough to finally drive Andrew out of the kernel business,
but 4 definitely would be.
The whole point is to try and get config-invariant build breakages, so
that we become less dependent on lots of randconfig testing. If the
definedness of the KCONFIG_ constants is still dependent on a particular
.config, then we're not really making all that much progress.
If we move to having a single unified kernel config rather than per-arch
ones (as Sam mentioned), then we can be sure of generating a complete
list of all config variables, and we can explicitly define them. But if
we don't move to that state more or less simultaneously with using
KCONFIG_ constants, then we should do it in the defeatest way so we can
make forward progress with minimal regression.
J
next prev parent reply other threads:[~2008-05-24 21:15 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 19:11 kernel coding style for if ... else which cross #ifdef Steve French
2008-05-23 20:42 ` Willy Tarreau
2008-05-23 20:49 ` Adrian Bunk
2008-05-23 21:05 ` Willy Tarreau
2008-05-23 23:03 ` H. Peter Anvin
2008-05-24 5:43 ` Sam Ravnborg
2008-05-24 5:42 ` H. Peter Anvin
2008-05-24 6:42 ` Sam Ravnborg
2008-05-24 10:06 ` Jeremy Fitzhardinge
2008-05-24 10:49 ` Adrian Bunk
2008-05-24 11:27 ` Sam Ravnborg
2008-05-24 14:35 ` Jeremy Fitzhardinge
2008-05-24 14:39 ` Willy Tarreau
2008-05-24 14:41 ` Jeremy Fitzhardinge
2008-05-24 14:46 ` Willy Tarreau
2008-05-24 15:36 ` Sam Ravnborg
2008-05-24 15:45 ` Jeremy Fitzhardinge
2008-05-24 15:57 ` Vegard Nossum
2008-05-24 16:02 ` Jeremy Fitzhardinge
2008-05-24 16:40 ` Tom Spink
2008-05-24 16:42 ` Tom Spink
2008-05-24 20:38 ` Jeremy Fitzhardinge
2008-05-24 20:43 ` H. Peter Anvin
2008-05-24 20:51 ` Jeremy Fitzhardinge
2008-05-24 20:54 ` H. Peter Anvin
2008-05-24 21:15 ` Jeremy Fitzhardinge [this message]
2008-05-25 23:57 ` Adrian Bunk
2008-05-26 0:27 ` H. Peter Anvin
2008-05-24 18:12 ` H. Peter Anvin
2008-05-24 18:12 ` H. Peter Anvin
2008-05-24 18:51 ` Sam Ravnborg
2008-05-24 18:08 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4838855F.2090701@goop.org \
--to=jeremy@goop.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=smfrench@gmail.com \
--cc=tspink@gmail.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox