From: "H. Peter Anvin" <hpa@zytor.com>
To: Rik van Riel <riel@redhat.com>
Cc: "Kristian Høgsberg" <krh@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot decompressor.
Date: Sat, 24 May 2008 21:06:44 -0700 [thread overview]
Message-ID: <4838E5D4.4050708@zytor.com> (raw)
In-Reply-To: <20080525000330.3eedd788@riellaptop.surriel.com>
Rik van Riel wrote:
> On Fri, 23 May 2008 23:17:01 -0700
> "H. Peter Anvin" <hpa@zytor.com> wrote:
>
>> Uhm... except it doesn't live at address zero, at all.
>>
>> It's called "zeropage" because we used to recycle it into
>> empty_zero_page, a long long time ago.
>>
>> The bootparms structure is pointed to by %esi being passed from the
>> setup code to the decompressor to the kernel.
>
> Then why does dereferencing the uninitialized
> pointer work, both in the code before and after
> the patch?
>
> What am I misssing?
Heck if I know. It definitely *shouldn't* work...
-hpa
next prev parent reply other threads:[~2008-05-25 4:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 21:59 [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot decompressor Kristian Høgsberg
2008-05-23 21:59 ` [PATCH 2/2] Only print "Decompressing Linux" etc when 'noisy' is passed Kristian Høgsberg
2008-05-23 22:42 ` Johannes Weiner
2008-05-24 9:25 ` Mikael Pettersson
2008-05-24 18:07 ` Diego Calleja
2008-05-24 1:07 ` [PATCH 1/2] Use structs instead of hardcoded offsets in x86 boot decompressor Rik van Riel
2008-05-24 6:17 ` H. Peter Anvin
2008-05-25 4:03 ` Rik van Riel
2008-05-25 4:06 ` H. Peter Anvin [this message]
2008-05-25 4:25 ` Kristian Høgsberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4838E5D4.4050708@zytor.com \
--to=hpa@zytor.com \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox