From: Li Zefan <lizf@cn.fujitsu.com>
To: James.Bottomley@HansenPartnership.com
Cc: michaelc@cs.wisc.edu, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: [PATCH] scsi/libiscsi.c: return -errno rather than errno
Date: Tue, 27 May 2008 15:58:46 +0800 [thread overview]
Message-ID: <483BBF36.80500@cn.fujitsu.com> (raw)
iscsi_prep_scsi_cmd_pdu() returns EIO in a failing path,
but returns -errno in other paths.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
drivers/scsi/libiscsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index b43bf1d..d380f46 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -307,7 +307,7 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_cmd_task *ctask)
hdr->hlength = hdrlength & 0xFF;
if (conn->session->tt->init_cmd_task(conn->ctask))
- return EIO;
+ return -EIO;
conn->scsicmd_pdus_cnt++;
debug_scsi("iscsi prep [%s cid %d sc %p cdb 0x%x itt 0x%x "
-- 1.5.4.rc3
next reply other threads:[~2008-05-27 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-27 7:58 Li Zefan [this message]
2008-05-27 22:06 ` [PATCH] scsi/libiscsi.c: return -errno rather than errno Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483BBF36.80500@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox