From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757647AbYE0KgR (ORCPT ); Tue, 27 May 2008 06:36:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756386AbYE0Kfv (ORCPT ); Tue, 27 May 2008 06:35:51 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:34529 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757471AbYE0Kfu (ORCPT ); Tue, 27 May 2008 06:35:50 -0400 Message-ID: <483BE3FB.1010602@garzik.org> Date: Tue, 27 May 2008 06:35:39 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Carl-Daniel Hailfinger CC: Linus Torvalds , Jesper Krogh , Linux Kernel Mailing List , David Woodhouse Subject: Re: Linux 2.6.26-rc4 References: <483B2A9B.4050007@krogh.cc> <483B60DB.7020402@gmx.net> In-Reply-To: <483B60DB.7020402@gmx.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Carl-Daniel Hailfinger wrote: > New code should look like > static struct pci_device_id ck804xrom_pci_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0051), .driver_data = DEV_CK804 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0360), .driver_data = DEV_MCP55 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0361), .driver_data = DEV_MCP55 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0362), .driver_data = DEV_MCP55 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0363), .driver_data = DEV_MCP55 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0364), .driver_data = DEV_MCP55 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0365), .driver_data = DEV_MCP55 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0366), .driver_data = DEV_MCP55 }, > { PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, 0x0367), .driver_data = DEV_MCP55 }, > { 0, } > }; Actually, more like { PCI_VDEVICE(NVIDIA, 0x0367), DEV_MCP55 }, Regards, Jeff