The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nadia Derbey <Nadia.Derbey@bull.net>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ipc/sem.c: remove unused entries from struct sem_queue
Date: Thu, 29 May 2008 17:02:14 +0200	[thread overview]
Message-ID: <483EC576.8080702@bull.net> (raw)
In-Reply-To: <200805241637.m4OGbBVo006252@mail.q-ag.de>

Manfred Spraul wrote:
> sem_queue.sma and sem_queue.id were never used, the attached
> patch removes them.
> 
> Signed-Off-By: Manfred Spraul <manfred@colorfullife.com>

Reviewed-By: Nadia Derbey <Nadia.Derbey@bull.net>

> ---
>  include/linux/sem.h |    2 --
>  ipc/sem.c           |    2 --
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/sem.h b/include/linux/sem.h
> index 6a1af1b..87756ef 100644
> --- a/include/linux/sem.h
> +++ b/include/linux/sem.h
> @@ -107,8 +107,6 @@ struct sem_queue {
>  	struct sem_undo *	undo;	 /* undo structure */
>  	int    			pid;	 /* process id of requesting process */
>  	int    			status;	 /* completion status of operation */
> -	struct sem_array *	sma;	 /* semaphore array for operations */
> -	int			id;	 /* internal sem id */
>  	struct sembuf *		sops;	 /* array of pending operations */
>  	int			nsops;	 /* number of operations */
>  	int			alter;   /* does the operation alter the array? */
> diff --git a/ipc/sem.c b/ipc/sem.c
> index 211632e..8cd96f1 100644
> --- a/ipc/sem.c
> +++ b/ipc/sem.c
> @@ -1160,12 +1160,10 @@ asmlinkage long sys_semtimedop(int semid, struct sembuf __user *tsops,
>  	 * task into the pending queue and go to sleep.
>  	 */
>  		
> -	queue.sma = sma;
>  	queue.sops = sops;
>  	queue.nsops = nsops;
>  	queue.undo = un;
>  	queue.pid = task_tgid_vnr(current);
> -	queue.id = semid;
>  	queue.alter = alter;
>  	if (alter)
>  		append_to_queue(sma ,&queue);




      reply	other threads:[~2008-05-29 15:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-24 11:23 [PATCH 2/4] ipc/sem.c: remove unused entries from struct sem_queue Manfred Spraul
2008-05-29 15:02 ` Nadia Derbey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483EC576.8080702@bull.net \
    --to=nadia.derbey@bull.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox