public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Cammarata <jimi@sngx.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: add ability to clear stats via ethtool - e1000/pcnet32
Date: Thu, 29 May 2008 12:15:16 -0500	[thread overview]
Message-ID: <483EE4A4.20508@sngx.net> (raw)
In-Reply-To: <20080529154525.3916c7b5@core>

> For one quite a few of the network cards keep the stats in hardware and
> don't neccessarily have a way to reset them. In other cases there is a
> mix of OS accumulated stats bulk updated by overflow events on the device
> itself.

Yes, and there's no good way to get around that, so the best thing for that 
hardware would probably to not add this functionality, in which case ethtool
would simply report that it's not available.  
 
> Its a lot of complexity, and changes all over the places for the sake of
> a trivial userspace change. I would suggest you instead write a quick bit
> of perl or python that fetches the stats and then updates every second
> with the changes.

I would disagree with you on the complexity issue.  In general, it is one
new function (trivial in length) and an addition to the ethtool ops.  SNMP
and sar cover the reporting needs, but there have been multiple times when
troubleshooting under the gun that this would have been extremely useful
to help diagnose the issue (in one instance, we were getting floods of 
jumbo frames and other errors, and we did not know how quickly they were 
accumulating, because the switch was not seeing the same problem).  My day
job is in the financial industry, so we are often under very short SLA's 
to diagnose issues, and having this built into the kernel/existing tools
would be a boon.  I'd be more than happy to change this to a kernel config
option, experimental and default off for those who would not want it.

  reply	other threads:[~2008-05-29 17:14 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-16 15:18 [PATCH updated] net: add ability to clear per-interface network statistics via procfs James Cammarata
2008-05-16 16:20 ` Eric Dumazet
2008-05-16 20:03   ` David Miller
2008-05-17 14:54   ` James Cammarata
2008-05-17 21:41     ` Eric Dumazet
2008-05-17 22:49       ` James Cammarata
2008-05-18  0:31         ` Ben Hutchings
2008-05-18  1:43           ` Patrick McHardy
2008-05-18  5:09           ` James Cammarata
2008-05-18 11:27             ` Ben Hutchings
2008-05-29  1:45             ` [PATCH] net: add ability to clear stats via ethtool - e1000/pcnet32 James Cammarata
2008-05-29  2:08               ` James Cammarata
2008-05-29  5:11               ` Andrew Morton
2008-05-29 12:34                 ` James Cammarata
2008-05-29 14:45                   ` Alan Cox
2008-05-29 17:15                     ` James Cammarata [this message]
2008-05-29 20:50                       ` David Miller
2008-05-29 21:18                         ` James Cammarata
2008-05-30 19:12                     ` Bill Fink
2008-05-30 22:14                       ` Rick Jones
2008-05-31  1:09                         ` Bill Fink
2008-05-31  2:41                           ` Stephen Hemminger
2008-05-31  4:47                             ` Bill Fink
2008-05-31 12:11                       ` Alan Cox
2008-05-31 23:57                         ` Bill Fink
2008-06-01  1:46                           ` Ben Hutchings
2008-06-01 20:46                             ` Bill Fink
2008-06-01 22:29                               ` Ben Hutchings
2008-06-02  3:55                                 ` Bill Fink
2008-06-02  5:39                               ` David Miller
2008-06-02 15:41                                 ` Bill Fink
2008-06-02  4:50                           ` Glen Turner
2008-06-02 16:10                             ` Bill Fink
2008-06-03 12:28                               ` James Cammarata
2008-06-03 12:35                                 ` Ben Hutchings
2008-06-03 14:46                                 ` Alan Cox
2008-06-04  3:05                                   ` James Cammarata
2008-05-29 14:48                   ` Chris Friesen
2008-05-16 20:00 ` [PATCH updated] net: add ability to clear per-interface network statistics via procfs David Miller
2008-05-16 20:09   ` Rick Jones
2008-05-17 15:06     ` James Cammarata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483EE4A4.20508@sngx.net \
    --to=jimi@sngx.net \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox