Re: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl

Jeff Garzik
2008-05-29T18:26:20Z

Alan Cox wrote:
> maybe_altstatus is crap naming but simply making ata_sff_altstatus fake a
> reply in arbitary cases risks not catching mistakes and could mean we
> don't catch corrupting mistakes which would be very bad indeed.

Please grep the remaining users, IMO you will find that's not really
true. After your patch no core users remain, only ones in a few
scattered drivers that most likely want your logic (or a
simplified-for-that-controller version thereof).

Jeff