Re: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl

Alan Cox
2008-05-29T20:33:26Z

> The old function oopsed for the case that you worry about. That is WORSE
> than anything else you can come up with. There is absolutely zero upside
> to using that old and broken thing.

The worst case is uncaught data corruption. An oops is harmless in
comparison. Someone using altstatus to enforce DMA timing barriers and
getting nothing else will find their disk contents 'degraded'.

I'm just putting together a patch that removes ata_altstatus entirely
from public use, and that actually looks far nicer.