public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matheos Worku <Matheos.Worku@Sun.COM>
To: David Miller <davem@davemloft.net>
Cc: jesper@krogh.cc, yhlu.kernel@gmail.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: NIU - Sun Neptune 10g - Transmit timed out reset (2.6.24)
Date: Thu, 29 May 2008 17:14:29 -0700	[thread overview]
Message-ID: <483F46E5.9030707@sun.com> (raw)
In-Reply-To: <20080528.223415.193732490.davem@davemloft.net>

David Miller wrote:

>From: Matheos Worku <Matheos.Worku@Sun.COM>
>Date: Tue, 27 May 2008 18:18:57 -0700
>
>  
>
>>Considering that fixing the HW would take considerable time, I was 
>>wondering if the scheme we use in the nxge driver could be considered as 
>>a workaround. Since the niu driver is already doing skb_orphan as a work 
>>around, what if  already transmitted TX buffers are  reclaimed 
>>periodically, within dev->hard_start_xmit() ?  Then TX_DESC_MARK would 
>>be set if/when available TX descriptor count falls below some watermark. 
>>Disable device TX queue about the time  TX_DESC_MARK is set and enable 
>>it within TX interrupt.
>>    
>>
>
>Since my hack patch didn't fix his problem at all, are you suggesting
>that we end up not fielding TX mark interrupts even though mark is set
>in all the TX descriptors and this is what hangs the chip?
>
>I find that very unlikely, especially because with my test patch every
>single TX descriptor will have the mark bit set and therefore we'd
>have to not receive all of those TX mark interrupts in order for the
>TX unit to hang like that.
>
>Something else must be going wrong.
>  
>
Dave,
Actually what I am suggesting was a workaround for the lack of "TX Ring 
Empty" interrupt by not relying on the TX interrupt at all.  As for the 
TX hang, I will try to reproduce the problem and look at the registers 
for the clue.

Regards
Matheos


  reply	other threads:[~2008-05-30  0:14 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07 18:23 NIU - Sun Neptune 10g - Transmit timed out reset (2.6.24) Jesper Krogh
2008-05-07 18:30 ` Yinghai Lu
2008-05-07 21:15   ` David Miller
2008-05-09 18:32     ` Jesper Krogh
2008-05-09 21:32       ` David Miller
2008-05-09 21:59         ` Jesper Krogh
2008-05-09 22:07           ` David Miller
2008-05-09 22:13             ` Jesper Krogh
2008-05-09 22:09           ` Matheos Worku
2008-05-09 22:15             ` Jesper Krogh
2008-05-09 22:36               ` Matheos Worku
2008-05-09 22:43                 ` Matheos Worku
2008-05-09 22:46                   ` David Miller
2008-05-09 23:10                   ` Jesper Krogh
2008-05-09 23:21                     ` Matheos Worku
2008-05-09 22:45                 ` David Miller
2008-05-22 16:32                   ` Jesper Krogh
2008-05-22 17:15                     ` Ben Hutchings
2008-05-22 17:41                     ` David Miller
2008-05-22 18:14                       ` Ben Hutchings
2008-05-22 18:28                         ` David Miller
2008-06-01  7:25                       ` Andrey Panin
2008-06-01 16:01                         ` David Miller
2008-05-09 22:20           ` Rick Jones
2008-05-09 22:48             ` Jesper Krogh
2008-05-09 23:03               ` Rick Jones
2008-05-09 23:13                 ` Jesper Krogh
2008-05-09 23:33                   ` Rick Jones
2008-05-09 23:08               ` David Dillow
2008-05-10  6:22                 ` Jesper Krogh
2008-05-10 15:53                   ` Roland Dreier
2008-05-12  6:49                     ` Jesper Krogh
2008-05-10  2:20               ` Bill Fink
2008-05-10 11:01       ` Jesper Krogh
2008-05-11  4:34         ` David Miller
2008-05-11  5:44           ` Jesper Krogh
2008-05-11  6:08             ` David Miller
2008-05-11  9:47               ` Jesper Krogh
2008-05-12  6:52           ` Jesper Krogh
2008-05-26 19:03             ` Jesper Krogh
2008-05-26 19:33               ` David Miller
2008-05-26 19:39                 ` David Miller
2008-05-26 20:54                   ` Jesper Krogh
2008-05-26 22:15                     ` David Miller
2008-05-26 22:21                       ` Jesper Krogh
2008-05-26 22:30                         ` David Miller
2008-05-27  6:19                       ` Jesper Krogh
2008-05-28  1:18                         ` Matheos Worku
2008-05-29  5:34                           ` David Miller
2008-05-30  0:14                             ` Matheos Worku [this message]
2008-05-30  7:00                               ` David Miller
2008-06-16 18:09                                 ` Matheos Worku
2008-06-16 18:21                                   ` Jesper Krogh
2008-06-18  0:02                           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483F46E5.9030707@sun.com \
    --to=matheos.worku@sun.com \
    --cc=davem@davemloft.net \
    --cc=jesper@krogh.cc \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox