From: Eric Sandeen <sandeen@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael Halcrow <mhalcrow@us.ibm.com>,
shaggy@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eCryptfs: Remove unnecessary page decrypt call
Date: Thu, 29 May 2008 19:17:24 -0500 [thread overview]
Message-ID: <483F4794.9040807@redhat.com> (raw)
In-Reply-To: <20080529163643.4c2620fb.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Thu, 29 May 2008 17:08:17 -0500
> Michael Halcrow <mhalcrow@us.ibm.com> wrote:
>
>> The page decrypt calls in ecryptfs_write() are both pointless and
>> buggy.
>
> buggy enough to be fixed in 2.6.26? 2.6.25.x?
IMHO yes... fsx w/ mmap dies quickly ( < 100 ops) without this, and
survives nicely (to millions of ops+) with it in place.
-Eric
next prev parent reply other threads:[~2008-05-30 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 22:08 [PATCH] eCryptfs: Remove unnecessary page decrypt call Michael Halcrow
2008-05-29 23:36 ` Andrew Morton
2008-05-30 0:17 ` Eric Sandeen [this message]
2008-05-30 19:14 ` Michael Halcrow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483F4794.9040807@redhat.com \
--to=sandeen@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=shaggy@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox