Re: [PATCH] sched: CPU hotplug events must not destroy scheduler domains created by the cpusets

Max Krasnyansky
2008-06-02T17:55:19Z

Paul Jackson wrote:
> I think this patch is ok --- though

> (1) perhaps it should have been two patches, as it seems to fix two bugs, and
I could split cpusets fix out I suppose.

> (2) I only managed to get my head about 80% of
> the way around this, so while I confident enough to Ack this one, I'm not
> as certain as I might be.
>
> Acked-by: Paul Jackson <pj@sgi.com>
Thanx.

> I did see a couple of places where the code could be more clearly presented,
> and a couple of lines ending in space characters in *.c files (the Doc files
> are hopelessly failing this space terminator test, so I gave up on them.)
> [snip]
I'll fix the spaces and redo the scheduler parts based on your suggestions.
As usual, nice and thorough review. Thanx.

Max