Re: [patch 26/41] cpu alloc: Convert mib handling to cpu alloc

Eric Dumazet
2008-05-30T06:48:00Z

Christoph Lameter a écrit :
> Use the cpu alloc functions for the mib handling functions in the net
> layer. The API for snmp_mib_free() is changed to add a size parameter
> since cpu_free() requires a size parameter.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> ---
> include/net/ip.h | 2 +-
> include/net/snmp.h | 32 ++++++++------------------------
> net/dccp/proto.c | 2 +-
> net/ipv4/af_inet.c | 31 +++++++++++++++++--------------
> net/ipv6/addrconf.c | 11 ++++++-----
> net/ipv6/af_inet6.c | 20 +++++++++++---------
> net/sctp/protocol.c | 2 +-
> net/xfrm/xfrm_proc.c | 4 ++--
> 8 files changed, 47 insertions(+), 57 deletions(-)
>
We also can avoid the use of two arrays when CONFIG_HAVE_CPU_OPS
since _CPU_INC() and __CPU_INC() are both interrupt safe.
This would reduce size of mibs by 50% and complexity (no need to sum)