From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756178AbYE3J37 (ORCPT ); Fri, 30 May 2008 05:29:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752432AbYE3J3t (ORCPT ); Fri, 30 May 2008 05:29:49 -0400 Received: from nf-out-0910.google.com ([64.233.182.186]:19457 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbYE3J3s (ORCPT ); Fri, 30 May 2008 05:29:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=OzWW0nctZc18dLBbj5rkQqfeocx3koinv/ElDLc3cBk5CZWlcnZ42vKGLmU1kVWzOoTI6x8H9B+zA1DUJypchGZbw4bjLRB2dB4HCu7/lupbU3x/80mrT1rRctTFU4IJqDqQQpeQci9+uTfGA/AO/aLYB/xBuFZ1DkQOEo/4dGo= Message-ID: <483FC90E.3020404@gmail.com> Date: Fri, 30 May 2008 11:29:50 +0200 From: Roel User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Vegard Nossum CC: linux-kernel@vger.kernel.org, Jan Engelhardt , Sverre Rabbelier , Joe Perches , git@vger.kernel.org Subject: Re: whomto.pl -- finding out whom to send patches to References: <20080529210018.GA5508@damson.getinternet.no> In-Reply-To: <20080529210018.GA5508@damson.getinternet.no> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vegard Nossum schreef: > Hi, > > I've written this perl script that takes a patch as input and prints the > authors/committers of the affected lines, using git-blame as the back end. > > (The purpose of this is of course to find out whom to send patches to.) > > There are some caveats: > > - If I've understood correctly, git-blame incremental output doesn't split > commits when a newer one is found, so we currently possibly take into > account more than just the last patch to touch a line. This might not be > a disadvantage, however... > > - The patch must apply to the current working tree. I suppose there is > some way to use the index information in the patch to determine what to > run git-blame against, but this is currently beyond my git knowledge. > > - It's a bit slow, particularly for large files. But doing the same thing > by hand would be slower, so I suppose it's an overall improvement. > > Running this on a random -mm patch, for example > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.26-rc2/2.6.26-rc2-mm1/broken-out/acpi-fix-fadt-parsing.patch > gives the following output: > > $ perl whomto2.pl acpi-fix-fadt-parsing.patch > Running git-blame on drivers/acpi/tables/tbfadt.c... > > To: (Committers) > 48 Len Brown > Cc: (Authors) > 44 Bob Moore > 2 Alexey Starikovskiy > 2 Len Brown > > Maybe this tool can be useful? :-) > > (Improvements are of course also welcome.) > > > Vegard Based on Linus' script to get the email address of a maintainer, I wrote this bash script to get an indication of relevant lists. Maybe you can make use of the part that parses the MAINTAINERS file for relevant lists? --- git log --since="1 year ago" "$@" | sed -n "s/^ .[-a-z]*by: \(.*\) <.*$/\1/p" | sort | uniq | sort -n -r | while read -r name; do sed -n "/^P:[ \t]*.*$name/,/^$/{ s/^L:[ \t]*\(.*\)$/\1/p }" ./MAINTAINERS done | sort | uniq -c | sort -n -r | while read -r nr list; do tot=`grep -c "^L:\W*.*$list.*" ./MAINTAINERS` echo "`expr $nr / \( $tot + 1 \)` $nr $tot $list" done | sort -r | cut -d " " -f2- | while read -r nr tot list; do echo -e "$nr/$tot Acks were commited by maintainers of list $list" done