From: "Joseph Guo (OSS)" <qijian.guo@oss.nxp.com>
To: Daniel Baluta <daniel.baluta@oss.nxp.com>,
Joseph Guo <qijian.guo@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
xinyu.chen@nxp.com, justin.jiang@nxp.com
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: add i.MX95 19x19 FRDM PRO board dts
Date: Wed, 29 Apr 2026 17:29:43 +0800 [thread overview]
Message-ID: <484067f8-aaa4-4d05-9e35-be9ecb0de41d@oss.nxp.com> (raw)
In-Reply-To: <f7257d2d-61d8-42e1-b589-874da203d851@oss.nxp.com>
On 4/29/2026 5:31 PM, Daniel Baluta wrote:
> On 4/29/26 12:26, Joseph Guo (OSS) wrote:
>> On 4/29/2026 5:26 PM, Daniel Baluta wrote:
>>> [snip]
>>>
>>>> +
>>>> +&flexcan1 {
>>>> + phys = <&flexcan1_phy>;
>>>> + pinctrl-0 = <&pinctrl_flexcan1>;
>>>> + pinctrl-names = "default";
>>>> + status = "disabled";
>>>> +};
>>>
>>> Why add this if it is disabled?
>>
>> Hi Daniel,
>>
>> The resource of flexcan1 in System Manager is assign to M7 by default. But it is useful if we assign the resource back to A55.
>> The board hardware have the output pin of flexcan1, so I keep the node here but set it disabled by default.
>
> Well then at least add a comment above to explain this.
Thanks to point out this. Will add comment in next version.
Regards,
Joseph
next prev parent reply other threads:[~2026-04-29 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 8:03 [PATCH v2 0/2] Add NXP FRDM-IMX95-PRO board support Joseph Guo
2026-04-28 8:03 ` [PATCH v2 1/2] dt-bindings: arm: fsl: Add i.MX95 19x19 FRDM PRO board Joseph Guo
2026-04-28 8:03 ` [PATCH v2 2/2] arm64: dts: freescale: add i.MX95 19x19 FRDM PRO board dts Joseph Guo
2026-04-29 1:37 ` Fabio Estevam
2026-04-29 4:17 ` Joseph Guo (OSS)
2026-04-29 9:26 ` Daniel Baluta
2026-04-29 9:26 ` Joseph Guo (OSS)
2026-04-29 9:31 ` Daniel Baluta
2026-04-29 9:29 ` Joseph Guo (OSS) [this message]
2026-04-29 12:46 ` Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484067f8-aaa4-4d05-9e35-be9ecb0de41d@oss.nxp.com \
--to=qijian.guo@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@oss.nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=justin.jiang@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qijian.guo@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xinyu.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox