Re: [patch 14/15] PNP: support optional IRQ resources

Bjorn Helgaas
2008-06-03T20:21:15Z

On Tuesday 03 June 2008 11:37:05 am Rene Herman wrote:
> > Index: work10/include/linux/ioport.h
> > ===================================================================
> > --- work10.orig/include/linux/ioport.h 2008-05-20 13:34:58.000000000 -0600
> > +++ work10/include/linux/ioport.h 2008-05-20 13:39:21.000000000 -0600
> > @@ -59,6 +59,7 @@ struct resource_list {
> > #define IORESOURCE_IRQ_HIGHLEVEL (1<<2)
> > #define IORESOURCE_IRQ_LOWLEVEL (1<<3)
> > #define IORESOURCE_IRQ_SHAREABLE (1<<4)
> > +#define IORESOURCE_IRQ_OPTIONAL (1<<5)
> >
> > /* ISA PnP DMA specific bits (IORESOURCE_BITS) */
> > #define IORESOURCE_DMA_TYPE_MASK (3<<0)
>
> Andrew scooped up a patch from a previous reaction of mine that deleted
> the "ISA " from these comments. I tend to use comments as a great way of
> avoiding actually reading code (I'm silly like that) and so as to be
> burned a _bit_ less by it, I think it's good if they're accurate. In
> this case for example, one might be tempted to assume these bits were
> specific to drivers/pnp/isapnp.

Yes, I see that's pnpacpi-fix-irq-flag-decoding-comment-fix.patch
in mmotm. How about if I incorporate that in my series (the one
Andrew hasn't yet picked up), since your patch will otherwise
conflict with it?

Bjorn