Re: [PATCH 1/2] cpusets: restructure the function update_cpumask() and update_nodemask()

Li Zefan
2008-06-04T02:18:32Z

Andrew Morton wrote:
> On Wed, 04 Jun 2008 10:00:34 +0800 Miao Xie <miaox@cn.fujitsu.com> wrote:
>
>> on 2008-6-4 8:55 Li Zefan wrote:
>>> Andrew Morton wrote:
>>>> On Mon, 02 Jun 2008 16:31:05 +0800
>>>> Miao Xie <miaox@cn.fujitsu.com> wrote:
>>>>
>>>>> extract two functions from update_cpumask() and update_nodemask().They will be
>>>>> used later for updating tasks' cpus_allowed and mems_allowed after CPU/NODE
>>>>> offline/online.
>>>> Unfortunately this patch conflicts with
>>>> http://userweb.kernel.org/~akpm/mmotm/broken-out/cpusets-fix-bug-when-adding-nonexistent-cpu-or-mem.patch
>>>>
>>>> Please check that the patch which I merged still makes sense. ie: that
>>>> we did not revert the effects of that bugfix.
>>>>
>>> They are fixing 2 different bugs, so they are irrelated, but unfortunately conflict in
>>> the code due to Miao's first patch which does code restructuring.
>>>
>> Right. I will modify my patches.
>
> I already did that, didn't I?
>

Oh, I just had a look at that, and yes you did that, but in a wrong way. :(

You reverted the effects of this bugfix:
cpusets-fix-bug-when-adding-nonexistent-cpu-or-mem.patch