From: Max Krasnyansky <maxk@qualcomm.com>
To: Paul Jackson <pj@sgi.com>
Cc: mingo@elte.hu, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org, menage@google.com,
rostedt@goodmis.org
Subject: Re: [PATCH] sched: CPU hotplug events must not destroy scheduler domains created by the cpusets
Date: Mon, 02 Jun 2008 10:55:19 -0700 [thread overview]
Message-ID: <48443407.2080707@qualcomm.com> (raw)
In-Reply-To: <20080602101902.cf8cdf11.pj@sgi.com>
Paul Jackson wrote:
> I think this patch is ok --- though
> (1) perhaps it should have been two patches, as it seems to fix two bugs, and
I could split cpusets fix out I suppose.
> (2) I only managed to get my head about 80% of
> the way around this, so while I confident enough to Ack this one, I'm not
> as certain as I might be.
>
> Acked-by: Paul Jackson <pj@sgi.com>
Thanx.
> I did see a couple of places where the code could be more clearly presented,
> and a couple of lines ending in space characters in *.c files (the Doc files
> are hopelessly failing this space terminator test, so I gave up on them.)
> [snip]
I'll fix the spaces and redo the scheduler parts based on your suggestions.
As usual, nice and thorough review. Thanx.
Max
next prev parent reply other threads:[~2008-06-02 17:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 18:17 [PATCH] sched: CPU hotplug events must not destroy scheduler domains created by the cpusets Max Krasnyansky
2008-05-29 18:17 ` [PATCH] sched: Move cpu masks from kernel/sched.c into kernel/cpu.c Max Krasnyansky
2008-05-29 18:17 ` [PATCH] sched: Give cpusets exclusive control over sched domains (ie remove cpu_isolated_map) Max Krasnyansky
2008-05-29 22:37 ` Paul Jackson
2008-05-29 22:59 ` Max Krasnyanskiy
2008-05-30 0:12 ` Paul Jackson
2008-05-30 4:24 ` Max Krasnyansky
2008-05-30 6:52 ` Paul Jackson
2008-05-31 19:12 ` Max Krasnyansky
2008-06-01 9:21 ` Peter Zijlstra
2008-06-02 2:39 ` Paul Jackson
2008-06-02 2:35 ` Paul Jackson
2008-06-04 0:49 ` Paul Jackson
2008-05-29 23:26 ` [PATCH] sched: Move cpu masks from kernel/sched.c into kernel/cpu.c Paul Jackson
2008-05-30 4:08 ` Max Krasnyansky
2008-05-30 4:10 ` Paul Jackson
2008-06-02 15:19 ` [PATCH] sched: CPU hotplug events must not destroy scheduler domains created by the cpusets Paul Jackson
2008-06-02 17:55 ` Max Krasnyansky [this message]
2008-06-02 19:01 ` Max Krasnyansky
-- strict thread matches above, loose matches on Subject: below --
2008-06-02 21:08 Max Krasnyansky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48443407.2080707@qualcomm.com \
--to=maxk@qualcomm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=mingo@elte.hu \
--cc=pj@sgi.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox