Re: [PATCH 0/7] Boot IRQ quirks and rerouting

[Stefan Assmann <sassmann@suse.de>]

Jon Masters schrieb:
> I like the patch series, insomuch as the intention is good, and it does
> away with the special PCI IRQ quirk patches some of us are carrying in
> our vendor trees to temporarily workaround this problem[0]. Also, I'm
> extremely impressed with the research that went into this, since I
> repeatedly tried to get ahold of information about disabling this
> unfortunate "feature" of various bridges, without much success.
>   
In a perfect world these "features" as you call them should be disabled 
by the bios, but this is not happening everywhere. Some bioses seem to 
have code for that in ACPI others rely on the OS to do the work.
> However, I really am not happy with the implementation as it stands. The
> duplicated table of quirks that doesn't really fit in with the existing
> PCI quirks infrastructure, the weird naming of the kernel options, and
> various other things that Thomas has already mentioned in his reply.
> Therefore, I think this needs a bit more reworking before going in.
>   
We're already working on that thanks to Thomas' review and will send an 
updated patchset asap. If there's anything you'd like to have changed 
feel free to let us know.
> Thanks!
>
> Jon.
>
> [0] The real fix come when we move IRQ handling in RT to per-device
> threads, as is the longer term intention. Then you can quiesse the
> device immediately and not the mask/unmask cycle that fails here.
>
>
>   

Thanks :)
    Stefan

-- 
Stefan Assmann          | SUSE LINUX Products GmbH
Software Engineer       | Maxfeldstr. 5, D-90409 Nuernberg
Mail : sassmann@suse.de | GF: Markus Rex, HRB 16746 (AG Nuernberg)