From: Larry Finger <Larry.Finger@lwfinger.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Compiler warning in v2.6.26-rc4-213-ge97dcb0
Date: Wed, 04 Jun 2008 16:53:22 -0500 [thread overview]
Message-ID: <48470ED2.6030307@lwfinger.net> (raw)
With the version given in the subject, I get the following warning:
CC drivers/serial/serial_core.o
drivers/serial/serial_core.c:2300: warning: initialization from incompatible
pointer type
The problem arises in commit 64e9159f5d2c which has uart_set_ldisc as follows:
static void uart_set_ldisc(struct tty_struct *tty, int ldisc)
The set_ldisc routine has only one argument:
void (*set_ldisc)(struct uart_port *);
I think this additional patch fixes the problem:
Index: linux-2.6/drivers/serial/serial_core.c
===================================================================
--- linux-2.6.orig/drivers/serial/serial_core.c
+++ linux-2.6/drivers/serial/serial_core.c
@@ -1165,7 +1165,7 @@ out:
return ret;
}
-static void uart_set_ldisc(struct tty_struct *tty, int ldisc)
+static void uart_set_ldisc(struct tty_struct *tty)
{
struct uart_state *state = tty->driver_data;
struct uart_port *port = state->port;
Larry
reply other threads:[~2008-06-04 21:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48470ED2.6030307@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox