* Compiler warning in v2.6.26-rc4-213-ge97dcb0
@ 2008-06-04 21:53 Larry Finger
0 siblings, 0 replies; only message in thread
From: Larry Finger @ 2008-06-04 21:53 UTC (permalink / raw)
To: Alan Cox, Linus Torvalds; +Cc: LKML
With the version given in the subject, I get the following warning:
CC drivers/serial/serial_core.o
drivers/serial/serial_core.c:2300: warning: initialization from incompatible
pointer type
The problem arises in commit 64e9159f5d2c which has uart_set_ldisc as follows:
static void uart_set_ldisc(struct tty_struct *tty, int ldisc)
The set_ldisc routine has only one argument:
void (*set_ldisc)(struct uart_port *);
I think this additional patch fixes the problem:
Index: linux-2.6/drivers/serial/serial_core.c
===================================================================
--- linux-2.6.orig/drivers/serial/serial_core.c
+++ linux-2.6/drivers/serial/serial_core.c
@@ -1165,7 +1165,7 @@ out:
return ret;
}
-static void uart_set_ldisc(struct tty_struct *tty, int ldisc)
+static void uart_set_ldisc(struct tty_struct *tty)
{
struct uart_state *state = tty->driver_data;
struct uart_port *port = state->port;
Larry
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-06-04 21:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-04 21:53 Compiler warning in v2.6.26-rc4-213-ge97dcb0 Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox