From: Jeff Garzik <jeff@garzik.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/18] firmware: moving drivers to request_firmware()
Date: Thu, 05 Jun 2008 16:12:12 -0400 [thread overview]
Message-ID: <4848489C.6010903@garzik.org> (raw)
In-Reply-To: <1212695675.32207.288.camel@pmac.infradead.org>
David Woodhouse wrote:
> On Thu, 2008-06-05 at 15:16 -0400, Jeff Garzik wrote:
>> Why do we need the .ihex format?
>>
>> We should be loading firmwares exactly as they come from the vendor,
>> without any wrappers.
>
> It's just 'objcopy -Ibinary -Oihex foo foo.ihex'. It's purely for
> convenience of handling the binary blobs in git (and it means we can
> append licensing information after the EOF record too, if we want).
Well, I should ask, is this purely an internal build detail?
The developer (and user) should never ever see a .ihex file, outside of
an active kernel compile. Wrapping the original firmware makes it more
difficult to verify, compare and/or change. In-tree, we should see the
vendor firmware blobs as shipped, with no wrapping or modification or
anything.
Any metadata can be added as a separate file.
If .ihex is purely a temporary thing during compile, no big deal, ignore
me. Otherwise, that's something we should avoid.
Jeff
next prev parent reply other threads:[~2008-06-05 20:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 9:52 [PATCH 00/18] firmware: moving drivers to request_firmware() David Woodhouse
2008-05-23 12:52 ` [PATCH 01/18] firmware: allow firmware files to be built into kernel image David Woodhouse
2008-05-23 12:58 ` [PATCH 02/18] firmware: Add CONFIG_BUILTIN_FIRMWARE option David Woodhouse
2008-05-26 22:01 ` [PATCH 04/18] firmware: convert korg1212 driver to use firmware loader exclusively David Woodhouse
2008-05-29 8:01 ` [PATCH 03/18] firmware: Add 'firmware_install' make target David Woodhouse
2008-05-29 11:48 ` [PATCH 05/18] firmware: convert maestro3 driver to use firmware loader exclusively David Woodhouse
2008-05-29 12:07 ` [PATCH 06/18] firmware: convert ymfpci " David Woodhouse
2008-05-29 13:39 ` [PATCH 07/18] smctr: use request_firmware() David Woodhouse
2008-05-29 14:17 ` [PATCH 08/18] kaweth: " David Woodhouse
2008-05-29 16:50 ` [PATCH 09/18] ttusb-budget: " David Woodhouse
2008-05-30 10:57 ` [PATCH 10/18] ihex.h: binary representation of ihex records David Woodhouse
2008-06-05 12:26 ` Clemens Ladisch
2008-05-31 22:20 ` David Woodhouse
2008-05-30 12:15 ` [PATCH 14/18] keyspan_pda: use request_firmware() David Woodhouse
2008-05-30 15:49 ` [PATCH 17/18] ti_usb_3410_5052: " David Woodhouse
2008-05-30 22:35 ` [PATCH 18/18] whiteheat: " David Woodhouse
2008-05-31 12:07 ` [PATCH 12/18] ihex: add ihex2fw tool for converting HEX files into firmware images David Woodhouse
2008-05-31 12:20 ` [PATCH 11/18] ihex: request_ihex_firmware() function to load and validate firmware David Woodhouse
2008-06-05 10:07 ` [PATCH 00/18] firmware: moving drivers to request_firmware() Arkadiusz Miskiewicz
2008-06-05 10:09 ` David Woodhouse
2008-06-05 12:26 ` Clemens Ladisch
2008-06-05 19:16 ` Jeff Garzik
2008-06-05 19:54 ` David Woodhouse
2008-06-05 20:12 ` Jeff Garzik [this message]
2008-06-05 20:53 ` David Woodhouse
2008-06-05 21:01 ` Jeff Garzik
2008-05-31 21:22 ` David Woodhouse
2008-06-05 21:33 ` Jeff Garzik
2008-05-31 22:15 ` David Woodhouse
2008-06-05 22:11 ` Jeff Garzik
2008-05-31 22:18 ` David Woodhouse
2008-06-05 22:39 ` Jeff Garzik
2008-05-31 22:45 ` David Woodhouse
2008-06-06 9:15 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4848489C.6010903@garzik.org \
--to=jeff@garzik.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox