Re: [PATCH] x86: set PAE PHYSICAL_MASK_SHIFT to match 64-bit

Jan Beulich
2008-06-05T15:34:23Z

>The 46-bit mask used in 64-bit seems pretty arbitrary. The physical
>size could be between 40 and 52 bits. Setting the mask to 40 bits
>would restrict the physical size to 1TB, which is definitely too
>small. Setting it to 52 would be ridiculously large, and runs the
>risk that one of the vendors may decide to put flags rather than
>physical address in one of the upper reserved bits.

Hmm? There's 11 bits available - why would anyone want to assign bits
from the sufficiently official (at least as far as AMD is concerned, I'm not
sure I saw a precise statement on Intel's side) frame number bits? And
even if they would, it would certainly take some control register bit to
enable the feature, so shrinking the mask if that would ever happen
would seem more appropriate.

Bottom line - I'd suggest pushing both 32- and 64-bits up to 52.

Jan